7
votes
Accepted
Real time Tic Tac Toe game in Javascript using Socket.IO
Server-side code
Looks pretty good!
However, as discussed in the comments, your server should probably be checking the game state to curtail cheating. As it is, it's pretty easy to "win" by fiddling ...
- 33k
6
votes
Accepted
Node websockets
In node, throwing an error without catching it will kill the process. This seems to be the primary error handling mode (and based on this it seems you then rely on pm2 to restart the process). This ...
- 311
3
votes
NodeJS/Express/socket.io backend
A short review;
Your database related functions should be separated, in my mind your socket methods should only do this:
Normalize parameters your receive like with ...
- 33.8k
2
votes
Accepted
Basic chat server and client using WebSocket
In regards to the TODO comment, I would suggest something like this:
...
- 86
2
votes
Accepted
An Express route, which renders a page, and makes use of socket.io
Conditional line not in brackets
There is an if statement in queryAPI() without brackets. This impacts readability greatly- ...
- 28.3k
2
votes
An Express route, which renders a page, and makes use of socket.io
Linting
The code reads well.
There is one convention you missed: use \s to indicate whitespace.
...
- 13.9k
2
votes
Accepted
Await socket Response
You have a few flags (removed, responded) which are almost equivalent and possibly useless. ...
- 10.5k
1
vote
Accepted
9X9 Tic Tac Toe variant with frontend in react and backend in python flask_socketio
I'm not fantastic with Typescript; so let's take a look at your Python:
Credentials
app.config['SECRET_KEY'] = 'secret!'
This shouldn't be baked into your code. ...
- 65.2k
1
vote
Socket.io Node.js Object Oriented Code Structure Approach
Good comments from @Magnus Jeffs Tovslid that I would like to add to.
It seems like you have at least three logical layers to the user experience. First, you have what you call the ...
- 9,638
1
vote
Socket.io Node.js Object Oriented Code Structure Approach
Just a few comments:
1:
The Room class can quickly become a place to throw in all sorts of functionality, even when it's not needed by all its children.
I would be careful to not put much there at ...
- 1,206
Only top scored, non community-wiki answers of a minimum length are eligible