5
To add to existing review a few points I noticed:
You are mixing up under_score (clear_webpage_board) and camelCase naming (createArray). Typically functions in javascript use camelCase (you can see that in all built-in methods that you use, including the borrowed createArray).
Css on the other hand typically uses naming, where dash is used, so thick-right, ...
3
Let's start with some convention things, in JS we (everyone) write function and variable names as camel case.
I see you have a comment that you tried to use a setter, the issue is that you would then want to use it in two ways. You would want to write this.board = import_string to call the setter, but in the constructor you do
this.board = this....
3
I know this is a couple weeks old, and you already have a good solution. I just wanted to point out a method that is a bit more deterministic/declarative.
You are already using multiple instances of gatsby-source-filesystem, and they each have their own name property. That becomes sourceInstanceName on the File nodes. You can use that value to simplify ...
2
From my experience, this is a good first cut solution for a less experienced candidate as opposed to some experienced candidate. Also, a lot of other info is missing in question such as was there any further discussion on how to improve the solution or about adapting some good practices or how to make this code bug free etc.
I will try to list down possible ...
2
The code is mostly easy to read- indentation seems consistent, though the CSS rules are not separated by new lines - a common convention among many style guides. There are a few comments and many functions/methods are self-documenting but it would be good to comment each function/method to be thorough, especially if you intend to have others utilize the code....
1
Thank you so much for the input! It gave me great insight into solving this problem.
Thanks @Jeremy Albright for your insight and advice. It inspired me to rewrite my node.js file.
My setup so far:
// gatsby-node.js
exports.createPages = require("./gatsby/node/createPages")
exports.onCreateNode = require("./gatsby/node/onCreateNode")
I'm still learning ...
Only top voted, non community-wiki answers of a minimum length are eligible
