Search Results

I wrote this code as an answer to a question. But I'd like you to have a look at it. This post is basically a copy of the answer I posted. The code does no error checking. It assumes that the output b …

My first suggestion is actually to remove most of the comments. Sometimes comments are useful, but when they are explaining obvious things, they just clutter the code. Also, since validate checks the …

A very simple stopwatch. Intended to be used for simple benchmarking when you want to do a task several times, but exclude some setup code from the benchmarking. Some things I have already considered: …

We all know the classic version of counting the number of elements in a C array: sizeof(a)/sizeof(*a) But this is dangerous, because if used on a pointer it will return garbage values. …

First thing I think of is that you have a pretty long main. You should split the code in more functions. Your code could look like this: long long readCardnumber(); bool validateChecksum(long long ca …

When it comes to performance, the only real way to know which method that is faster is to benchmark it. In many cases we can make educated guesses, but nothing can replace testing the code. Once snipp …

(Apart from that, for fgets(sData, 20, stdin) you have to declare sData to have a size of at least 21 if you want to treat it like a regular C-string. Don't I need to free() in every case? …

I would do six changes: Better variable names, especially for the arguments Remove unnecessary temporary array Handle negative numbers Initialize temporary array with memset instead of a loop. Comme …

As we all know, the syntax of allocating memory is a bit clunky in C. …

is a source file (dough) SRC = $(wildcard *.c) # Every source file should be compiled to an object file OBJ = $(SRC:.c=.o) # Every object file should have a dependency file DEP = $(OBJ:.o=.d) # Link the … exe from the object files $(EXE): $(OBJ) $(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) # Generate dependencies for the object files %.o: %.c $(CC) -MMD -MP -c $< -o $@ # https://stackoverflow.com/q/2145590 …

malloc I start with one of the most common ones. Instead of char *board = malloc(sizeof(char) * BOARD_SIZE) write char *board = malloc(sizeof(*board) * BOARD_SIZE). If you decide to change the type i …

Choice of language I understand you probably want to do this in C, but I felt it was worth mentioning that Python is a much more suitable language for this task. … ptr) is so common in C that it adds almost no readability. Comments You're using some unmotivated comments. Like when you are wasting 7(!) …