Questions tagged [comparative-review]
This tag is used for questions which present a problem and multiple solutions, where the asker wishes to know which solution is best (and why).
848
questions
2
votes
0answers
12 views
Text centered in a circular component
I have surrounded my initials with a circle. This is intended to be a re-usable component in a responsive layout. (When it is re-used the text will always be two letters, and the font won't change. It ...
6
votes
2answers
210 views
Solution discussion on the best way to reverse a number in Python
I'm practicing some python exercise and I have some doubts about the solution of reversing a number. Example, 42 -> 24, -314 -> -413.
The book has this solution:
...
4
votes
1answer
55 views
LeetCode 1115: Print FooBar Alternately
I'm posting two solutions for LeetCode's "Print FooBar Alternately". If you'd like to review, please do. Thank you!
Problem
Suppose you are given the following code:
...
3
votes
0answers
24 views
React Higher Order Components - export wrapped component or wrap it in parent?
I've been learning about about how to use context, and how to make a higher order component to provide context values through props.
So, I've created my HOC to pass down the props, and it looks like ...
1
vote
1answer
56 views
LeetCode 863: All Nodes Distance K in Binary Tree
I'm posting two similar solutions for LeetCode's "All Nodes Distance K in Binary Tree". If you'd like to review, please do so. Thank you!
Problem
We are given a binary tree (with root node <...
0
votes
2answers
81 views
Which is better practice for this if elif… else statement? [closed]
If below piece of code has to be restructured to use but one single if-elif block, which is better? 1. or 2.?
A = int(input("Enter an integer(1~30): "))
...
3
votes
2answers
81 views
Is the following divide and conquer recursive algorithm for the exponentiation more efficient than the iterative one for large numbers?
I have the two following algorithms. My analysis says that both of them are \$\mathcal O(m^24^n)\$ i.e they are equivalent for big numbers (more than 32 bits). Is this right? Note that ...
10
votes
5answers
2k views
Print a word, one character per line, backwards
I have a problem that I solved in 2 different ways and I would like to know which one is better, cleaner and easier to read.
Problem:
Write a while loop that starts at the last character in the
string ...
2
votes
2answers
71 views
Common Unit Testing Code – Follow Up
This question is a follow up question to the Common Unit Testing Code portion of my lexical analyzer questions.
My primary concern is the code in the header file and the C source file that implements ...
4
votes
2answers
61 views
An example of transferring the C ++ class hierarchy to Golang. Is it done correctly?
I am trying to transfer my c ++ experience to the Go area. I'm new to Go, so not sure if the implementation is correct. In any case, it looks very ugly compared to C ++ code. Is there a nicer solution?...
3
votes
0answers
69 views
Providing a connection pool
I need some opinions about method naming and single responsibility principle.
First of all, let's talk about method naming. The class below was created to provide a connection pool and whenever a pool ...
2
votes
0answers
73 views
Any ideas how do I prettify this SQL query?
This question is abut coding style. I'd like to see how would you improve this code look considering readability as well. Feel free to upvote others solutions you find good.
#1 Initial version:
...
7
votes
6answers
2k views
Checking if an integer is a palindrome using either a string or a dict
I have solved the palindrome question on LeetCode today, but I wasn't happy with the original solution - I used strings, it worked slowly and used a lot of memory.
So I rewrote the answer using a ...
5
votes
2answers
54 views
Print a right-justified list of a list
I'm working through Chapter 6 in "Automate the Boring Stuff, 2nd Edition." Here is the chapter project at the end.
Write a function named printTable() that takes a list of lists of strings ...
1
vote
2answers
99 views
Return row count from mysqli prepared statement
I want to know if it is okay/safe to use a prepared statement and mysqli_num_rows like this:
...
1
vote
2answers
52 views
Looking at the hill of indents seems like this can be improved
I've spent some time on this as an answer elsewhere, and did my best to optimize it. But looking at the hill of indents seems like this can be improved. I've tried to implement an ...
6
votes
4answers
1k views
Computing the item price and vat for a given pricing, order, and exchange rate
How can I improve the readability of the below function using a list comprehension?
Also, is there a way to improve items() performance?
...
3
votes
1answer
49 views
Checking inactivity with periodic tasks in Java
I have created a simple HealthCheck service. I have two approaches:
Create a task canceling the previous one if the system is active, rescheduling the new task.
Create a periodic task and regularly ...
4
votes
1answer
96 views
Extracting member-accesses from an expression in C#
I need to extract all member accesses to expression parameter (and make sure, that they are not nested). For instance, for expression: a => a.A + a.B I need to ...
1
vote
1answer
104 views
LeetCode 200: Number of Islands
I'm posting my code for a LeetCode problem. If you'd like to review, please do so. Thank you for your time!
Problem
Given a 2d grid map of '1's (land) and '0's (water), count the number
of islands. ...
3
votes
1answer
54 views
Laravel Scope get request data/param
I want to pass the param from the request on the scope method in the model and serve it as json to be rendered by select2. Which is better?
1. Pass request from the controller like this
controller:
<...
1
vote
0answers
56 views
What is the best implementation of a ignore case dictionary In C#
Imagine we have a custom dictionary class which is derived from Dictionary<string, object>. Dictionary is case-insensitive about keys and elements arrange is ...
1
vote
1answer
41 views
Encasing a string in double quotes
I need to add some characters to a String before using it for an API call. The idea is to add a " char both at the beginning and at the end of the String, to make ...
2
votes
2answers
49 views
Smartly joining possibly empty strings
I want to join two fragments into one string with a separator, but when one of the fragments is empty I only want one of them.
I have two implementations. The first is long and slightly repetitive, ...
2
votes
0answers
29 views
What is a better practice in bash scripts to test if string is empty: [[ -z ${value//[0-9]/“”} ]] or ! [[ ${value//[0-9]/“”} ]]?
I test in a bash script if a variable value contains digits only.
There are two options, both give the valid results:
...
3
votes
1answer
104 views
In Memory Database in Unit tests, isolate the tests
I have stumbled across these unit tests in a code review that are using in memory db:
...
0
votes
4answers
91 views
Java method refactoring: getting the file name or path
I have been learning about refactoring and I have this method that I'm wondering if I should split into two for code cleanness. First, the method as one, next the method split in two:
Method not ...
2
votes
0answers
52 views
Why does my Clojure implementation of Conway's Game of Life run so much slower than my Java implementation?
I'm trying to learn Clojure coming from a Java background. I have written a simple implementation of Conway's game of life in both Clojure and Java, trying to keep the overall structure of the code as ...
1
vote
2answers
37 views
Copying List Elements To Another List And Changing Them
I'm a beginner python programmer..I recently started reading a python book called: "Python Crash Course, 2nd Edition: A Hands-On, Project-Based Introduction to Programming"...And I found an ...
6
votes
1answer
501 views
Recursive LinkedList. Which implementation is better and why?
class Node:
def __init__(self, data):
self.data = data
self.next = None
class LinkedList:
def __init__(self):
self.head = None
<...
3
votes
1answer
66 views
Maximum distance between space stations HackerRank
I am just working on Flatland Space Stations problem, and it is not seeming to be a tough question, but my algorithm lags in some aspects, since it solves majority of the test cases but fails for some....
6
votes
2answers
992 views
Python Class Coding Simplification
Main purpose of this code,
Take some information for animal features
Clasification of user input
print those input into txt file
My problem is that, I think coding of animal features takes too much ...
3
votes
1answer
55 views
A simple animation in pygame
I'm following a tutorial into pygame. I realized the example code was written for the sake of being easy to understand. I wondered if I could 'improve' the code, with a focus on keeping the exact same ...
4
votes
2answers
67 views
Builder design pattern pass object
Good Morning
This is a builder design pattern .. the builder problem is duplication so
I want to know from an expert with explanation which is better on quality on this code:
(1)
...
6
votes
2answers
405 views
Implementing web scraping in a function and in a class
The goal of my code is to implement a web scraping routine to obtain the name and the price of a product. I want to put this routine separated from the main program file. Sample url to scrape: https://...
3
votes
0answers
51 views
Simple beginner Rust CLI file reader that prints to stdout
Q: Am I approaching writing idiomatic Rust code correctly?
Hi CodeReview, I'm a beginner Rustacean coming from Python going through Rust books (The Rust Book, Rust in Action). A lot of the beginner ...
0
votes
0answers
35 views
Report writing, do the formatting work on database or non-database language?
When report writing, sometimes getting the data you need can be quite straightforward in SQL, but getting the data in the exact format you'll need it in for the specific report can be quite tricky.
It'...
4
votes
1answer
46 views
Finding missing void keywords in C source code
I'm writing a bash script to search C source files and find the lines where I missed the void keyword (unlike in C++, in C, empty parameter lists have to be indicated with the void keyword).
I read ...
1
vote
1answer
239 views
Best practice to initialize instance variables for a POJO when values are null
I am using Java 8. I haven't found another question that fits mine exactly, and I've come across some conflicting information on best practices with what I'm trying to do.
I'm creating a POJO which ...
2
votes
1answer
113 views
Simple BST implementation using C++ Struct
I am trying to implement DSs in C++ and this is BST insert and search functions. I tried in two different ways, please review and see if one is advantageous over other.
With pointer to pointer
...
23
votes
11answers
6k views
Find nth Fibonacci Number, using iteration and recursion
I'm a beginner programmer and I came upon this problem which is to find the nth number in the Fibonacci series.
I used to solve the problem using a for loop; ...
3
votes
1answer
148 views
Convenience function to save and load pickle objects
I want to come up with a simple convenience function to save and load pickle objects. A secondary objective is to simply execute the function without the above function. I have come up with two ...
2
votes
0answers
150 views
generic implementation approaches for a recursive function
Let's take the famous fibonacci problem as an example but this is a generic problem. Also, taking scala as the language as it's rather feature-rich. I want to know which solution you'd prefer.
we all ...
-1
votes
1answer
87 views
abstract base classes versus the curiously recurring template pattern [closed]
Background
Apologies for "burying the lead." The questions are in the next section.
In my application, the purpose of inheritance is to abstract away complicated logic in the base class template, so ...
6
votes
3answers
265 views
C# Event Manager without allocations
I'm using my own Action-based Event Manager for a while and looking for ways to improve it.
Mainly it's used in game development, where excessive garbage generation can lead to severe consequences. ...
0
votes
1answer
59 views
Schedule talks in tracks [closed]
Consider my simple business requirement as follows:
There is a list of talks and they need to be scheduled in tracks. Each track has a morning session starting at 9am and an afternoon session starting ...
3
votes
2answers
66 views
Organise method flow
I have something like a shop. It is limited to a checkout page, which will send an email. Nothing big, but a nice thing to learn more OOP.
Almost every time I develop new classes I am wondering how ...
7
votes
3answers
590 views
C++/Opengl voxel renderer
I have tried going back to C++ after long time of mainly doing C#. I realize that the code is far from perfect, however I would really appreciate if someone could point of what exactly is wrong and ...
5
votes
3answers
343 views
0
votes
2answers
73 views
Implementation of the Selection Sort Algorithm
I have tried to implement the Selection Sort Algorithm in two different ways, and I was just wondering if that is considered to be a valid implementation of that algorithm. Would that be also ...
