Questions tagged [comparative-review]
This tag is used for questions which present a problem and multiple solutions, where the asker wishes to know which solution is best (and why).
874
questions
0
votes
3answers
64 views
2
votes
2answers
88 views
Counting uppercase and lowercase characters in a string
I created two programs (one with JAVA8) to calculate the total count of uppercase and lowercase characters in given String. After checking the execution time JAVA8 is taking longer execution time than ...
3
votes
2answers
172 views
Parsing custom text file using haskell
I am working on writing code for find difference between two text files that should be ideally same.
the format of file is
...
3
votes
1answer
62 views
Posts data to endpoint, trying not to use .Result on async methods
I have a Send method that is working but want to refactor a portion where it is using PostAsync().Result and ReadAsStringAsync().Result. I've never written async methods before and don't feel I ...
2
votes
1answer
74 views
Dose tracker with daily and weekly totals
This is an old script I made a while ago.
What it does
It tracks your dose of whatever you want tracked (cigarettes, salt, etc), outputs the total for each day, and the full week.
What I’m looking for
...
3
votes
1answer
94 views
Find the largest decrease in a sequence of numbers
I have written a function that takes as input a list of 5 numbers, then the program's goal is to return the largest drop in the list. It is important to understand that [5, 3, ...] is a decrease of 2 ...
3
votes
1answer
35 views
Using Numba works slower than not using it for my Python code
I thought this community is better place to ask my question so I ask here rather than at StackOverflow.
Recently, I learned that Numba can make Python function ...
5
votes
2answers
259 views
Spliting Greeter class to multiple small classes
Write a Greeter class with greet function that receives a name as input and outputs ...
3
votes
0answers
38 views
class uploade file(photo,video,..) laravel
I am working on a project, the previous programmer used this method to save photos, videos, etc.
...
5
votes
1answer
103 views
Copy Columns Forward Macro: From Procedural to OOP
Background: I had created a macro few years ago and when I was reviewing this now, it was hard to understand.
I recently went through all the articles from ...
1
vote
2answers
139 views
URLify a given String - replace spaces with %20
I have written a code to replace all spaces in a String with %20.
...
2
votes
1answer
49 views
Which solution of the two is the most efficient? Is there a better one? (IP Address Defang)
I just started doing preparation for interviews, but im having trouble recognizing the optimal solution
Problem: For a given IP Address, replace every "." with "[.]"
Example:
...
1
vote
1answer
59 views
How can I refactor for handling multiple proto generated service clients by eliminating double await and the DRY code?
I'm having doubts about which is the best strategy to manage the many service clients in this web app.
"Best" in terms of a good compromise between user's device RAM and Javascript execution ...
1
vote
1answer
48 views
Changing an element in a list when a predicate holds
My current project is a Settlers of Catan server in Haskell. I often manage to achieve my goals within Haskell, but the code is getting messier as the project grows.
My question is about the ...
1
vote
0answers
37 views
Asking for feedback, when utilizing Pandas, why is it better to use pandas.Series than lists data type?
I found out the hard way, when utilizing pandas is better to use pandas.Series than lists data type to manipulate data.
Even if ...
2
votes
3answers
78 views
Sort an array of integers with a hashset
I was trying to make a sorting algorithm for an array of integers. Here's are the steps/theory:
It turns an array into a HashSet, iterates over every integer value ...
0
votes
1answer
64 views
need some guidance for better coding practice [closed]
Given a int optimumMemory and int[] array with list of available memories find the pair of indexes of memories whose sum of the values will be equal to the optimumMemory?
If there exists more than one ...
1
vote
0answers
27 views
Spectrograph using array-of-slice-references
I've written a working and complete proof of concept that shows a spectrograph in Matplotlib. I want to nail down this proof of concept before I continue with development, and I'm not thrilled with ...
3
votes
2answers
107 views
Debounce function that limits the rate a callback is triggered. Which implementation is better, and why?
The Debounce technique allow us to “group” multiple sequential calls in a single one - The debounce() function forces a function to wait a certain amount of time before running again.
I wrote both <...
15
votes
4answers
2k views
Get the first item in a sequence that matches a condition
I've been trying to figure out what's the best, most Pythonic way to get the first element of a sequence that matches a condition. Here are three options:
I don't like that I've written ...
2
votes
1answer
190 views
C++: swapping bytes of an uint64_t
This question is about swapping bytes of an uint64_t value, or in other words, about converting between endianness of an integer value:
...
1
vote
1answer
67 views
Perform various actions on a list
I am solving the following HackerRank problem:
Consider a list (list = []). You can perform the following commands:
insert i e: Insert integer e at position i.
<...
2
votes
0answers
36 views
Which of my string indexing functions in Kotlin is semantically closer to my Java one?
I have a working string indexing method in Java and did convert in Kotlin.
All methods shown below produce the same result but as I am really new to the Kotlin language I wanted to ask which of my two ...
9
votes
3answers
1k views
Two ways to remove duplicates from a list
The question is - Write a program to remove the duplicates in a list
Here's how I did it-
...
1
vote
1answer
55 views
Calculate how many days to add to a process based on destination country or state
I am refactoring a function that calculates how many days to add to a process based on destination country or state.
The original function called the database twice, even though the database table ...
4
votes
1answer
37 views
Text centered in a circular component
I have surrounded my initials with a circle. This is intended to be a re-usable component in a responsive layout. (When it is re-used the text will always be two letters, and the font won't change. It ...
6
votes
2answers
226 views
Solution discussion on the best way to reverse a number in Python
I'm practicing some python exercise and I have some doubts about the solution of reversing a number. Example, 42 -> 24, -314 -> -413.
The book has this solution:
...
4
votes
1answer
94 views
LeetCode 1115: Print FooBar Alternately
I'm posting two solutions for LeetCode's "Print FooBar Alternately". If you'd like to review, please do. Thank you!
Problem
Suppose you are given the following code:
...
3
votes
0answers
45 views
React Higher Order Components - export wrapped component or wrap it in parent?
I've been learning about about how to use context, and how to make a higher order component to provide context values through props.
So, I've created my HOC to pass down the props, and it looks like ...
4
votes
2answers
1k views
Convert array of u32 to Vec<u8> in Rust
In Rust, I want to take an array of u32 values, convert each to four bytes in big endian, and concatenate them to yield a ...
1
vote
1answer
110 views
LeetCode 863: All Nodes Distance K in Binary Tree
I'm posting two similar solutions for LeetCode's "All Nodes Distance K in Binary Tree". If you'd like to review, please do so. Thank you!
Problem
We are given a binary tree (with root node <...
0
votes
2answers
128 views
Which is better practice for this if elif… else statement? [closed]
If below piece of code has to be restructured to use but one single if-elif block, which is better? 1. or 2.?
A = int(input("Enter an integer(1~30): "))
...
3
votes
2answers
85 views
Is the following divide and conquer recursive algorithm for the exponentiation more efficient than the iterative one for large numbers?
I have the two following algorithms. My analysis says that both of them are \$\mathcal O(m^24^n)\$ i.e they are equivalent for big numbers (more than 32 bits). Is this right? Note that ...
10
votes
5answers
5k views
Print a word, one character per line, backwards
I have a problem that I solved in 2 different ways and I would like to know which one is better, cleaner and easier to read.
Problem:
Write a while loop that starts at the last character in the
string ...
2
votes
2answers
79 views
Common Unit Testing Code – Follow Up
This question is a follow up question to the Common Unit Testing Code portion of my lexical analyzer questions.
My primary concern is the code in the header file and the C source file that implements ...
4
votes
2answers
62 views
An example of transferring the C ++ class hierarchy to Golang. Is it done correctly?
I am trying to transfer my c ++ experience to the Go area. I'm new to Go, so not sure if the implementation is correct. In any case, it looks very ugly compared to C ++ code. Is there a nicer solution?...
3
votes
0answers
73 views
Providing a connection pool
I need some opinions about method naming and single responsibility principle.
First of all, let's talk about method naming. The class below was created to provide a connection pool and whenever a pool ...
3
votes
1answer
108 views
Any ideas how do I prettify this SQL query?
This question is abut coding style. I'd like to see how would you improve this code look considering readability as well. Feel free to upvote others solutions you find good.
#1 Initial version:
...
7
votes
6answers
2k views
Checking if an integer is a palindrome using either a string or a dict
I have solved the palindrome question on LeetCode today, but I wasn't happy with the original solution - I used strings, it worked slowly and used a lot of memory.
So I rewrote the answer using a ...
5
votes
2answers
85 views
Print a right-justified list of a list
I'm working through Chapter 6 in "Automate the Boring Stuff, 2nd Edition." Here is the chapter project at the end.
Write a function named printTable() that takes a list of lists of strings ...
1
vote
2answers
737 views
Return row count from mysqli prepared statement
I want to know if it is okay/safe to use a prepared statement and mysqli_num_rows like this:
...
1
vote
2answers
53 views
Looking at the hill of indents seems like this can be improved
I've spent some time on this as an answer elsewhere, and did my best to optimize it. But looking at the hill of indents seems like this can be improved. I've tried to implement an ...
6
votes
4answers
1k views
Computing the item price and vat for a given pricing, order, and exchange rate
How can I improve the readability of the below function using a list comprehension?
Also, is there a way to improve items() performance?
...
3
votes
1answer
59 views
Checking inactivity with periodic tasks in Java
I have created a simple HealthCheck service. I have two approaches:
Create a task canceling the previous one if the system is active, rescheduling the new task.
Create a periodic task and regularly ...
4
votes
1answer
120 views
Extracting member-accesses from an expression in C#
I need to extract all member accesses to expression parameter (and make sure, that they are not nested). For instance, for expression: a => a.A + a.B I need to ...
1
vote
1answer
147 views
LeetCode 200: Number of Islands
I'm posting my code for a LeetCode problem. If you'd like to review, please do so. Thank you for your time!
Problem
Given a 2d grid map of '1's (land) and '0's (water), count the number
of islands. ...
5
votes
1answer
452 views
Laravel Scope get request data/param
I want to pass the param from the request on the scope method in the model and serve it as json to be rendered by select2. Which is better?
1. Pass request from the controller like this
controller:
<...
1
vote
0answers
230 views
What is the best implementation of a ignore case dictionary In C#
Imagine we have a custom dictionary class which is derived from Dictionary<string, object>. Dictionary is case-insensitive about keys and elements arrange is ...
1
vote
1answer
50 views
Encasing a string in double quotes
I need to add some characters to a String before using it for an API call. The idea is to add a " char both at the beginning and at the end of the String, to make ...
3
votes
2answers
56 views
Smartly joining possibly empty strings
I want to join two fragments into one string with a separator, but when one of the fragments is empty I only want one of them.
I have two implementations. The first is long and slightly repetitive, ...
