Skip to main content
Code Review
flornquake's user avatar
flornquake's user avatar
flornquake's user avatar
flornquake
  • Member for 11 years, 7 months
  • Last seen more than a month ago
  • Vienna, Austria
Profile Activity

62 Actions

All Accepts Posts Badges Comments Revisions Reviews Suggestions
awarded
 Notable Question
awarded
 Popular Question
awarded
 Popular Question
accepted
Convert a hex string to base64
comment
Convert a hex string to base64
@Lundin This order of digits is how Base64 is typically defined (don't ask me why). Thanks for your review!
awarded
 Yearling
asked
Convert a hex string to base64
revised
Performance of dynamic Fibonacci generator and dead rabbits
small fixes
suggested
Approve
Performance of dynamic Fibonacci generator and dead rabbits
comment
Performance of dynamic Fibonacci generator and dead rabbits
You're going to have rounding errors if you implement this formula with floats. Also, math.pow(x,y) won't be faster than x**y if x (φ) is a float.
comment
Dice simulator program
while input(msg).lower() != 'exit': is a simpler way of writing the exit condition.
awarded
 Caucus
comment
Product of dictionary values
To make this work with doctest, one can (a) use OrderedDict on input and pprint (which sorts dictionaries) on output or (b) somewhat awkwardly construct a set of frozensets and compare it to an expected value.
comment
Check if an element is present within a linked list
Disagree with your first point; this data structure is definitely implemented as a linked list. I agree, though, that it doesn't offer all the methods that one might expect from a linked list interface, such as removal.
suggested
Cancel
class fizzbuzz():
awarded
 Autobiographer
awarded
 Yearling
comment
Python infinite product generator
you can write itertools.count() instead of .count(0). :)
comment
Python calculator script
int has unlimited precision. :)
comment
Python calculator script
z isn't global.
1
2 3 4