Search Results

I am not well versed in c and will defer to others for language particular concerns, but I hope I can say something helpful. I am very impressed with your diligence in checking for failures, whether …

Hello and welcome to Code Review. Surprisingly, a, b, and c are probably the best variable names you can come up with. They are conventionally given as canonical examples of bad names, but when the …

Usually, when you find yourself with multiple nested loops doing functionally the same thing, that's a good time to look for a solution using recursion, which are functions (you could indeed use gener …

First, I like the explicit statement of the type signature. That's a good habit to get into, and makes it easier to capitalise on perhaps the greatest strength of using Haskell which is all the compil …

Whenever you find yourself writing code that feels the same, consider whether you can create a function to do it. For example consider using a function for padding to two digits. Instead of turning …

I have never used Kotlin, so I can't give a comprehensive review or comment particularly on specific idioms. I'm slightly bothered by this line, because null objects seems very much like a Java habit …

vnp has already covered most of the big stuff, and I wholeheartedly agree with each point. I do have a few details that I thought worth mentioning: The inline and noexcept qualifiers seem entirely …

You should code to make sure that user input doesn't break any assumptions you are making about the game. For example, I like the gimmick that the players can pick a symbol. However, you should make s …

Janos has covered most of the key issues I could see. One question that I have is "why do you want your identifying strings to be random?" If you want to associate the url with an id, the easiest op …

if second>=len(s): break This is not necessary. You have just checked that in the loop condition. first=0 second=1 strang1='' strang2='' Consider renaming these variables to say what they d …

I like this code. I like the use of the @lru_cache decorator. I appreciate seeing the elegance of the recursive solution, while knowing it has the performance of a dynamic programming one. I like t …