Search Results

The class Products seems better named as Product (singular) since a table is a type of product, as is a chair. The methods in WoodenFactory could simply be static methods since they don't appear to d …

Is there a benefit to using Classes? Classes are "primarily syntactical sugar over JavaScript's existing prototype-based inheritance"1 . It is more efficient to declare methods on the prototype inst …

Before addressing the main question, I would like to compare two of the primary methods: register and get. The register method is written well in terms of returning early. public static function re …

Perhaps Simon is right with the comment: FWIW I think you should just use input parameters, it's not like anyone is going to type this out. But if you don't agree with that, then perhaps the si …

Use object-oriented style: $con = getCon(); $result = $con->query("SELECT * FROM sometable WHERE deleted=0"); Refer to Example #1 on the PHP documentation for mysqli_query(), as well as the Dual in …

[I] want to know if it properly represents PolyMorphism in JavaScript? Your code could be considered a representation of polymorphism when considering that the noOfSides() function was changed fo …

One other aspect I noticed is that the swap inclusion line uses the const statement. You could use const and let where appropriate. For example, in the method delete(), this line: var parent = this …

The getter method Weapon.timePerShot will return 1 / this.fireRate. There doesn't appear to be anything to prevent fireRate from being 0. If that is the case, Weapon.timePerShot would return Infinity, …

Potential for SQL injection Before getting to the main question I’d like to mention the code is vulnerable to SQL injection- possibly via methods like update(). It is explained in this article An SQL …

In the above code, Are there improvements? Yes there are quite a few improvements that can be made. Below are a few simplifications. There are a few places where else is used following a conditional …

Feedback The class looks like it is organized well for the most part- the methods generally handle a single task. However, some of those methods are a bit lengthy so could be broken up into smaller su …

Suggestions Before addressing the main question, there are some suggestions to mention first. S.O.L.I.D. principles If you aren't already familiar with them, look into the SOLID principles. The S is f …

is there a better way to achieve this functionality? You can use Function.bind() to create a function with the this context bound to Wyg.Editor: const node = document.getElementById('myFavoriteNode' …

How can the code be rewritten more efficiently? I see lot of repetition in it. Yes there is a lot of repetition in the code. The most common thing I spot is multiple places where AccountJournal::cre …

How can I get rid of functions in methods? You can start by making those in-line functions methods. For example, currentStep (the click handler) can be a method that accepts a click event argumen …