A simple C WinAPI program for terminating processes via process image names - follow-up

Question

(See the previous (i.e. first) version of this tool.)

(See the next follow-up.)

After taking into consideration all the advice by Martin R, I ended up with the following tool for terminating all the processes with given process image names:

#include <stdio.h>
#include <stdlib.h>
#include <windows.h>
#include <TlHelp32.h>

int main(int argc, char* argv[]) {
    if (argc != 2) {
        fprintf(stderr, "processkiller.exe PROCESS_NAME");
        return EXIT_FAILURE;
    }

    PROCESSENTRY32 entry;
    entry.dwSize = sizeof(PROCESSENTRY32);
    HANDLE snapshot = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, NULL);

    if (snapshot == INVALID_HANDLE_VALUE) {
        fputs("Error: could not get the process snapshot.", stderr);
        return EXIT_FAILURE;
    }

    size_t totalProcessesMatched = 0;
    size_t totalProcessesTerminated = 0;

    if (Process32First(snapshot, &entry)) {
        do {
            if (strcmp(entry.szExeFile, argv[1]) == 0) {
                totalProcessesMatched++;

                HANDLE hProcess = OpenProcess(PROCESS_TERMINATE, 
                                              FALSE, 
                                              entry.th32ProcessID);

                if (hProcess == NULL) {
                    fprintf(stderr,
                            "Error: could not open the process with ID = %d, "
                            "called \"%s\".\n", 
                            entry.th32ProcessID, 
                            entry.szExeFile);
                } else {
                    BOOL terminated = TerminateProcess(hProcess, 0);

                    if (terminated) {
                        totalProcessesTerminated++;

                        BOOL closed = CloseHandle(hProcess);

                        if (!closed) {
                            fprintf(stderr,
                                    "Warning: could not close a handle "
                                    "for process ID = %d, called \"%s\".\n",
                                    entry.th32ProcessID, 
                                    entry.szExeFile);
                        }

                        printf("Terminated process ID %d\n", entry.th32ProcessID);
                    }
                }
            }
        } while (Process32Next(snapshot, &entry));
    }

    BOOL snapshotHandleClosed = CloseHandle(snapshot);

    if (!snapshotHandleClosed) {
        fputs("Warning: could not close the process snapshot.", stderr);
    }

    printf("Info: total matching processes: %d, total terminated: %d.\n", 
           totalProcessesMatched, 
           totalProcessesTerminated);

    return EXIT_SUCCESS;
}

Critique request

Am I going anywhere? Is this tool coded properly? Am I sufficiently verbose about statistics/error information?

Answer 1

Regarding:

size_t totalProcessesMatched = 0;
size_t totalProcessesTerminated = 0;
...
printf("Info: total matching processes: %d, total terminated: %d.\n", 
       totalProcessesMatched, 
       totalProcessesTerminated);

the printf() is trying to output a int, but the variables to output are size_t which should be output using a %zu format specifier.

If you compiler is not telling you about these kinds of problems, then enable the warnings until it does.

regarding;

fprintf(stderr, "processkiller.exe PROCESS_NAME");  

This would be 1) left in the stderr output stream because the format string does not have a \n on the end of it. 2) any program can be executed via any name so hard coding the name is a bad idea. Suggest:

fprintf(stderr, "%s PROCESS_NAME\n", argv[0] );

regarding:

fputs("Error: could not get the process snapshot.", stderr);

strongly suggest making use of the get_last_error() facility and printing the actual error text to stderr rather than some 'random' error message

regarding;

if (strcmp(entry.szExeFile, argv[1]) == 0) {

this does not compile because the statement:

#include <string.h>

is missing.