A function that uses requests in order get JSON content

Question

Any typing, or other improvements that you could make for this simple function?

def get_json_parsed_from(url: Union[str, bytes]) -> Dict[Any, Any]:
    """Gets a JSON file and returns it parsed, or returns an empty dict if any error occurred."""
    try:
        headers = random_headers()
        headers['Accept'] = 'application/json,text/*;q=0.99'
        return dict(requests.get(url, headers=random_headers()).json())
    except BaseException:
        _LOGGER.exception('Failed getting JSON from %s', repr(url), exc_info=False)
        return {}

Answer 1

headers = random_headers()
headers['Accept'] = 'application/json,text/*;q=0.99'   
return dict(requests.get(url, headers=random_headers()).json())

• You are not using headers. You create it and adding the Accept key to it, but then passing a new call to random_headers() to .get instead of using headers.

• requests.get(...).json() already returns a dict. Passing it to dict(...) is superfluous.

This should be your code:

headers = random_headers()
headers['Accept'] = 'application/json,text/*;q=0.99'   
return requests.get(url, headers=headers).json()