5
\$\begingroup\$

Please understand my request before commenting, I'm looking for positive critiques of my work. Anything I've done which could be done better while using the same, or similar, restrictions on data types and #include files that I've used. To put it another way, if you see anything that could be done more efficiently, using the same restrictions, please advise.

I know there's more elegant ways to do this. I'm just trying to push my understanding of the basic C++ constructs, before getting into more advanced C++ implementations.

code:

//02_ex_03_guess_my_number_aplha
#include <iostream>
#include <ctime>
#include <cstdlib>

using namespace std;

int main()
{
    bool exitGame = false;
    bool playAgain = true;
    bool roundOver = false;
    char playAgainYes = 'y';
    int playModeSelect = 0;
    int computersNumber = 0;
    int tooLow = 0;
    int tooHigh = 101;
    int playersNumber = 0;
    int tries = 0;

    enum playMode { playerVersusCpu = 1, cpuVersusPlayer, exitMenu};
    srand(static_cast<unsigned int>(time(0)));

    cout << "\tGuess My Number alpha\n\n\n";

        do
        {
            cout << "1 - Player Versus Computer\n";
            cout << "2 - Computer Versus Player\n";
            cout << "3 - Exit\n";
            cout << "Select a game mode: ";

            cin >> playModeSelect;

            switch (playModeSelect)
            {
            case playerVersusCpu:
                cout << "You have selected Player VS Computer\n";
                do
                {
                    tries = 0;
                    playAgainYes = 'n';
                    cout << "Welcome. Try to guess my number: ";
                    computersNumber = (rand()) % 100 + 1;
                    do
                    {
                        cout << "DEBUG " << computersNumber;

                        cin >> playersNumber;
                        if (playersNumber > computersNumber)
                        {
                            cout << "Too bad. Your guess was too high.\n";
                            cout << "Try again: ";
                            ++tries;
                        }
                        else if (playersNumber < computersNumber)
                        {
                            cout << "Too bad. Your guess was too low.\n";
                            cout << "Try again: ";
                            ++tries;
                        }
                        else if (playersNumber = computersNumber)
                        {
                            cout << "You did it. You guessed my number.\n";
                            ++tries;
                            cout << "It only took you " << tries << " tries.\n";
                            do 
                            {
                                cout << "Would you like to play again? ('y'/'n'): ";
                                cin >> playAgainYes;
                                if (playAgainYes == 'y')
                                {
                                    playAgain = true;
                                    cout << playAgainYes << "DEBUG\n";
                                }
                                else if (playAgainYes == 'n')
                                {
                                    playAgain = false;
                                    cout << playAgainYes << "DEBUG\n";
                                }
                                else
                                {
                                    cout << "Inncorrect input\n";
                                    cout << "Select 'y' or 'n': ";
                                }
                            } while ((playAgainYes != 'y') && (playAgainYes != 'n' ));
                        }
                    } while (playersNumber != computersNumber);
                } while (playAgainYes == 'y');//
            break;

            case cpuVersusPlayer:
                cout << "\n\nYou have selected Computer VS Player\n";
            do
            {
                cout << "Pick a number: ";
                cin >> playersNumber;
                tries = 0;
                tooLow = 0;
                tooHigh = 101;
                do
                {
                    computersNumber = rand() % 100 + 1;
                    while ((computersNumber != playersNumber) && (computersNumber > tooLow) && (computersNumber < tooHigh))
                    {
                        ++tries;
                        cout << "Is it, " << computersNumber << "?\n";
                        cout << "This was my " << tries << " try.\n";
                        if ((computersNumber > tooLow) && (computersNumber < playersNumber))
                        {
                            tooLow = computersNumber;
                        }

                        else if ((computersNumber < tooHigh) && (computersNumber > playersNumber))
                        {
                            tooHigh = computersNumber;
                        }
                    }

                } while (computersNumber != playersNumber);
                cout << "Well then it has to be " << computersNumber << "\n";
                cout << "Only took me " << ++tries << " goes!\n\n";
                do
                {
                    cout << "Would you like to play again? ('y'/'n'): ";
                    cin >> playAgainYes;
                    if (playAgainYes == 'y')
                    {
                        playAgain = true;
                        cout << playAgainYes << "DEBUG\n";
                    }
                    else if (playAgainYes == 'n')
                    {
                        playAgain = false;
                        cout << playAgainYes << "DEBUG\n";
                    }
                    else
                    {
                        cout << "Inncorrect input\n";
                        cout << "Select 'y' or 'n': ";
                    }
                } while ((playAgainYes != 'y') && (playAgainYes != 'n'));
            } while (playAgainYes == 'y');
            break;

            case exitMenu:
                exitGame = true;
                break;

            default:
                cout << "Invalid selection. Please try again.\n";
                cout << "1 - Player Versus Computer\n";
                cout << "2 - Computer Versus Player\n";
                cout << "3 - Exit\n";
                cout << "Select a game mode: ";
                break;

            }

    } while (exitGame != true); //plan on implementing an escape feature to the program

    system("pause");

    return 0;
}
\$\endgroup\$
5
\$\begingroup\$

Starting with a few simple things:

using namespace std;

It's a poor idea to import the whole of std namespace into your program. Instead, I suggest you selectively take just those names you intend to use.

system("pause");

When using system(), you should always check its return value; in this particular case, it will always fail unless there's a pause program on the user's PATH. I have no such thing, and it doesn't seem to be in any common Linux distribution I've ever seen - it appears to be this anti-pattern.

Two variables are declared but never used: playAgain and roundOver.


On to the structure. The code looks like One Big Main(). It really helps to identify self-contained chunks of functionality and, especially, any re-usable parts of the program. So I'd write something more like:

int main()
{
    playMode playModeSelect;
    do {
        playModeSelect = selectPlayMode();
        switch (playModeSelect) {
        case playerVersusCpu:
            playComputersChoice();
            break;
        case cpuVersusPlayer:
            playPlayersChoice();
            break;
        case exitMenu:
            // do nothing here
            break;
        }
    } while (playModeSelect != exitMenu);
}

Having done that, we can implement the functions selectPlayMode(), playComputersChoice() and playPlayersChoice(). Let's start with selectPlayMode(). A function version of your code looks like:

playMode selectPlayMode()
{
    using std::cout;
    using std::cin;

    cout << "1 - Player Versus Computer\n";
    cout << "2 - Computer Versus Player\n";
    cout << "3 - Exit\n";
    cout << "Select a game mode: ";

    int playModeSelect;
    cin >> playModeSelect;
    return playMode(playModeSelect);
}

We can be more rigorous about ensuring that the displayed numbers match how we interpret them:

cout << playerVersusCpu << " - Player Versus Computer\n";
cout << cpuVersusPlayer << " - Computer Versus Player\n";
cout << exitMenu << " - Exit\n";
cout << "Select a game mode: " << std::flush;

Note that I've explicitly flushed the output stream before reading any input. This should happen anyway when switching between cout and cin, but it's good to be clear that this is what we want.


Now let's move on to playComputersChoice(). If we extract this into a function, we have:

void playComputersChoice()
{
    int computersNumber = (rand()) % 100 + 1;
    int tries = 0;
    std::cout << "Welcome. Try to guess my number: " << std::flush;
    int playersNumber;
    do {
        std::cin >> playersNumber;
        if (playersNumber > computersNumber)
            {
                std::cout << "Too bad. Your guess was too high.\n";
                std::cout << "Try again: " << std::flush;
                ++tries;
            }
        else if (playersNumber < computersNumber)
            {
                std::cout << "Too bad. Your guess was too low.\n";
                std::cout << "Try again: " << std::flush;
                ++tries;
            }
        else if (playersNumber = computersNumber)
            {
                std::cout << "You did it. You guessed my number.\n";
                ++tries;
                std::cout << "It only took you " << tries << " tries.\n";
            }
    } while (playersNumber != computersNumber);
}

Some things that I see here: in the if/else-if cascade, the last condition will always be true if the first two were false, so we can write a simple else there. Note also that we increment tries in each branch of the if, so we can hoist that statement so it's always executed. Finally, the do/while repeats the test of playersNumber against computersNumber; instead of that, we could write an infinite loop, and break out of it when the player wins:

void playComputersChoice()
{
    const int computersNumber = (rand()) % 100 + 1;
    std::cout << "Welcome. Try to guess my number: " << std::flush;
    for (int tries = 0;  ;  ++tries) {
        int playersNumber;
        std::cin >> playersNumber;
        if (playersNumber > computersNumber) {
            std::cout << "Too bad. Your guess was too high.\n"
                      << "Try again: " << std::flush;
        } else if (playersNumber < computersNumber) {
            std::cout << "Too bad. Your guess was too low.\n"
                      << "Try again: " << std::flush;
        } else {
            std::cout << "You did it. You guessed my number.\n"
                      << "It only took you " << tries << " tries.\n";
            return;
        }
    }
}

You'll see that I made computersNumber constant, to show that during this game, the computer can't change its secret number - that would be cheating! More seriously, the judicious use of const can help to avoid misunderstandings and mistakes.


Finally, let's have the computer do the guessing:

void playPlayersChoice()
{
    int playersNumber;
    std::cout << "Pick a number: " << std::flush;
    std::cin >> playersNumber;
    int tries = 0;
    int tooLow = 0;
    int tooHigh = 101;
    int computersNumber;
    do {
        computersNumber = rand() % 100 + 1;
        while ((computersNumber != playersNumber) && (computersNumber > tooLow) && (computersNumber < tooHigh)) {
            ++tries;
            std::cout << "Is it " << computersNumber << "?\n";
            std::cout << "This was my " << tries << " try.\n";
            if ((computersNumber > tooLow) && (computersNumber < playersNumber)) {
                tooLow = computersNumber;
            } else if ((computersNumber < tooHigh) && (computersNumber > playersNumber)) {
                tooHigh = computersNumber;
            }
        }

    } while (computersNumber != playersNumber);
    std::cout << "Well then it has to be " << computersNumber << "\n";
    std::cout << "Only took me " << ++tries << " goes!\n\n";
}

There's a few changes we can make here. First, we should ensure that the player's number is within the range 1-100, otherwise the computer can never guess it:

int playersNumber;
do {
    std::cout << "Pick a number: " << std::flush;
    std::cin >> playersNumber;
} while (playersNumber < 1 || playersNumber > 100);

Also, the computer should be able to use its previously determined high and low values when guessing:

    computersNumber = tooLow + 1 + rand() % (tooHigh-tooLow-1);

And we can use a similar loop to the player's game:

for (int tries = 0;  ;  ++tries) {

Now, something that applies throughout. What happens if you don't enter a number when asked? The >> operator will return false, but we never check it, and never fix up the stream. We definitely need some error handling, and to avoid writing the same code many times, we'll want it as a function:

int readInteger(const char *prompt)
{
    std::cout << prompt << std::flush;
    int n;
    if (std::cin >> n)
        return n;
    // else, clean up and ask again
    std::cin.clear();
    return readInteger(prompt);
}

I don't think you the "Play again (y/n)" question. Given that choice 3 from the menu is "exit", then asking whether to play again is redundant. You could go the other way, and remove the exit option instead.


My version

#include <iostream>
#include <ctime>
#include <cstdlib>
#include <string>

int readInteger(const char *prompt)
{
    std::cout << prompt << std::flush;
    int n;
    if (std::cin >> n)
        return n;
    // else, clean up and ask again
    std::cin.clear();
    std::string line;
    std::getline(std::cin, line);
    return readInteger(prompt);
}

void playComputersChoice()
{
    const int computersNumber = (rand()) % 100 + 1;
    std::cout << "Welcome. Try to guess my number.\n";
    for (int tries = 0;  ;  ++tries) {
        int playersNumber = readInteger("Your guess: ");
        if (playersNumber > computersNumber) {
            std::cout << "Too bad. Your guess was too high.\n";
        } else if (playersNumber < computersNumber) {
            std::cout << "Too bad. Your guess was too low.\n";
        } else {
            std::cout << "You did it. You guessed my number.\n"
                      << "It only took you " << tries << " tries.\n";
            return;
        }
    }
}

void playPlayersChoice()
{
    int playersNumber;
    do {
        playersNumber = readInteger("Pick a number: ");
    } while (playersNumber < 1 || playersNumber > 100);

    int tooLow = 0;
    int tooHigh = 101;
    for (int tries = 0;  ;  ++tries) {
        int computersNumber = tooLow + 1 + rand() % (tooHigh-tooLow-1);
        std::cout << "Is it " << computersNumber << "?\n";
        std::cout << "This was my " << tries << " try.\n";
        if (computersNumber < playersNumber) {
            tooLow = computersNumber;
        } else if (computersNumber > playersNumber) {
            tooHigh = computersNumber;
        } else {
            // found it
            std::cout << "Well then it has to be " << computersNumber << "\n";
            std::cout << "Only took me " << ++tries << " goes!\n\n";
            return;
        }
    }
}

enum playMode { playerVersusCpu = 1, cpuVersusPlayer, exitMenu};

playMode selectPlayMode()
{
    std::cout << playerVersusCpu << " - Player Versus Computer\n";
    std::cout << cpuVersusPlayer << " - Computer Versus Player\n";
    std::cout << exitMenu << " - Exit\n";

    return playMode(readInteger("Select a game mode: "));
}

int main()
{
    std::srand(static_cast<unsigned int>(std::time(nullptr)));

    playMode playModeSelect;
    do {
        playModeSelect = selectPlayMode();
        switch (playModeSelect) {
        case playerVersusCpu:
            playComputersChoice();
            break;
        case cpuVersusPlayer:
            playPlayersChoice();
            break;
        case exitMenu:
            // do nothing here
            break;
        }
    } while (playModeSelect != exitMenu);
}
|improve this answer|||||
\$\endgroup\$
  • \$\begingroup\$ [deleted my original comment] I should maybe state that I'm running W10 and Visual Studio 2015. I noticed that the std::getline wasn't found when I tried to compile. With int readInteger, I had to include <string> header. I understand there's something called relational inheritance? I'm not sure if this was the intention, a mistake, or platform specific implementation. A bit lost with how (const char *prompt) arguments work, the return(readInteger(prompt), std::cout << prompt << std::flush; I need a bit more explaining for these implementations. The rest of your revision makes perfect sense. \$\endgroup\$ – Patrick Canney Feb 23 '17 at 23:21
  • \$\begingroup\$ std::getline required the string header, my mistake. \$\endgroup\$ – Patrick Canney Feb 24 '17 at 3:11
  • \$\begingroup\$ I've marked the question as answered, though I may have failed to ask the question correctly due to my novice understanding of C++. \$\endgroup\$ – Patrick Canney Mar 18 '17 at 0:09

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.