how to filter text from a string and convert it to dictionary and check for matching values in python

Question

I am new to this community, I have tried this below code, this works fine, but looking for a better way of approaching for performance.

Please edit my question, it it is not understandable.

I have a string and list, I need to filter that and converting that string to a dictionary , then if a dictionary key presents in the list, we need to append the corresponding dict[value] to my list

text='p.O(post office)\nR.J(Radio Jocky)'
list1=["R.J"]
text_splitted=text.split("\n")
my_dict={}
for item in text_splitted:
    index=item.index("(")
    key=item[:index]
    value=item[index+1:len(item)-1]
    my_dict[key]=value
list2=[my_dict[item] for item in my_dict.keys() if item in list1]
list1=list1+list2
output:
list1=['R.J', 'Radio Jocky']

Answer 1

• I think the step of converting it to a list is unnecesarry, because we can check if it is in the list the same.
• I have a solution using regex to find the corresponding name and job
• You could use better variable names because item and list1 list2 are nondescriptive

Note that using wilcards .* would be considered bad form in a regex

You might want to change that to suit your needs.

---

from re import findall

def add_job(L, text):
    for line in text.split('\n'):
        name, job = findall(r"(.*)\((.*\))", line)[0]
        if name in L:
            L.append(job)
    return L

if __name__ == '__main__':
    text='p.O(post office)\nR.J(Radio Jocky)'
    list1=["R.J"]
    list1 = add_job(list1, text)
    print(list1)