Timeline for Bread formula object
Current License: CC BY-SA 3.0
17 events
when toggle format | what | by | license | comment | |
---|---|---|---|---|---|
Dec 1, 2015 at 20:03 | history | edited | Jamal | CC BY-SA 3.0 |
deleted 13 characters in body; edited title
|
Jan 9, 2013 at 20:42 | vote | accept | Thomas | ||
Jan 9, 2013 at 20:32 | vote | accept | Thomas | ||
Jan 9, 2013 at 20:33 | |||||
Jan 9, 2013 at 20:11 | comment | added | Bobson | I do mean calculated, but my point was that if you have all the information already, you don't need them to be nullable - just do the calculation in the constructor. There's no need for a separate function call to do the math later. And if you don't have all the information at first, then you should reconsider whether those values belong on the object - see my answer for another way to do it. | |
Jan 9, 2013 at 20:11 | answer | added | Josh Anderson | timeline score: 1 | |
Jan 9, 2013 at 19:59 | comment | added | Thomas | @Bobson By derived, do you mean calculated? I can (and do) calculate values from other properties and set those values (to replace) the nulls. | |
Jan 9, 2013 at 19:47 | history | tweeted | twitter.com/#!/StackCodeReview/status/289096110964867072 | ||
Jan 9, 2013 at 19:05 | answer | added | Edmondo | timeline score: 3 | |
Jan 9, 2013 at 18:58 | answer | added | Bobson | timeline score: 18 | |
Jan 9, 2013 at 18:08 | comment | added | Bobson | If you are always setting a field in the constructor, it doesn't need to be nullable. If you're never setting it to a useful value, it shouldn't be a parameter to the constructor. And if it can be derived entirely from other properties on the same object, it should be set by that object rather than calling a function to perform calculations on it. | |
Jan 9, 2013 at 17:58 | history | edited | svick | CC BY-SA 3.0 |
rm tag from title
|
Jan 9, 2013 at 16:38 | answer | added | mariosangiorgio | timeline score: 3 | |
Jan 9, 2013 at 16:27 | answer | added | Akim | timeline score: 2 | |
Jan 9, 2013 at 16:23 | answer | added | Jesse C. Slicer | timeline score: 7 | |
Jan 9, 2013 at 16:17 | review | First posts | |||
Jan 9, 2013 at 16:53 | |||||
Jan 9, 2013 at 16:16 | answer | added | Patryk Ćwiek | timeline score: 7 | |
Jan 9, 2013 at 15:58 | history | asked | Thomas | CC BY-SA 3.0 |