Skip to main content
Nihathrael's user avatar
Nihathrael's user avatar
Nihathrael's user avatar
Nihathrael
  • Member for 10 years, 1 month
  • Last seen more than 2 years ago
awarded
awarded
awarded
awarded
awarded
awarded
revised
Loading…
comment
AudioMetaTagger: recursively read files and gather metadata
@Scavence I had another look at some libraries for extracting meta data from audio files and found this one: jthink.net/jaudiotagger/examples_read.jsp Looks like it could do what you need (haven't tested it though).
revised
Loading…
revised
Loading…
Loading…
comment
Printer Color Templates
Hi, welcome to Code Review! Check python.org/dev/peps/pep-0008 for advice on how naming, formatting etc. is usually done with python. Probably a good place to start.
comment
Point2D.Double wrapper
@DimitrisK I agree that having the x and y public is not very nice. I don't think I'd go through the hassle of not extending Point2D.Double though, as this is a general Problem with the Point2D.Double. This is of course unless you are designing a public API (which is to be released and used as such [think: apache commons]), then using a wrapper is probably worth considering. But for "private" or "in project" use, I'd probably go with the simplistic approach of subclassing it.
comment
Point2D.Double wrapper
In case he wants to limit the API, that could be a valid reason. But since all methods except for setLocation of the original Point2D.Double are implemented in the wrapper, I do not see any benefit of having a wrapper. Especially as extending the class makes the new PointDouble2D easier to use, uses less code and provides more flexibility of use for the PointDouble2D class.