for ( String p : paramList ) { if (result.length() > 0) result.append( ", " ); result.append( p ); }

Start with a simple, easy to understand version. Try to reuse API functions. import java.util.Arrays; ... public boolean areAnagrams(String s1, String s2) { char[] ch1 = s1.toCharArray(); ...

Usually you get the advice to avoid multiple exit points in a method. However the reasoning behind this rule is only valid if you have long methods - and then you have more to worry about than exit ...

I wouldn't search for a "rule", just store the "truncate points" private final static int[] truncateSizes = {10,7,5,3,1,0}; public int generateListSize(int listSize) { for(int truncateSize : ...

If you can use Java 7, you can put Strings in switch statements (this came with JSR334): String fileId = "CPP420.A2_2012072416244467745"; String country = ""; String fileReg = fileId.split("...

There are a few things, I'll expand on this over time. First, always write method and variable names in lowerCamelCase. Everything starting with an uppercase letter wil be considered a class or a ...

I don't know Lisp, but you can speed up the calculation by observing that n² + 3n + 5 is never divisible by 11 (and hence never divisible by 121), except when n mod 11 == 4. If you check the ...

Refactor's answer is excellent and captures most points. One thing in your code which sticks out is the overuse of if. E.g. consider get_bounds xs = if null xs then (0, 0) else (length xs, ...

First, your process method violates the Single Responsibility Principle: It calculates something, and it prints it out. Such coupling makes it inflexible. It's better to return a String, and letting ...

Don't use arrays as representation for binary numbers. BitSet could save you a lot of work. Except from that, your code is very repetitive. An example: if ((A[idx] == '0' && B[idx] == '1'...

I see one small improvement. Instead of... i++; while ( i< r && a[i] < x) i++; j--; while (j>p && a[j] > x) j--; ...you can write: do { i++; } while (i < r &...

Additionally to the excellent answer from ratchet freak: Always encode data according to their meaning, don't use another type just because it seems more "convenient". E.g. variables like soft17 ...

If you are really sure that an empty method body is okay for most sub-classes, you could follow the example of Swing listeners (e.g. WindowListener / WindowAdapter): Make the methods in your Foo class ...

Your names could be improved, e.g. hm isn't a good name for a member variable. You could replace the HashMap by a multiset implementation, e.g. HashMultiset from Google Guava. Then you get putWord ...

for (row <- grid) { for (p <- row) { //should be written as: for(row <- grid; p <- row) { Tuple2("bla", 42) //should be written as ("bla", 42) I don't really understand why you use ...

In my opinion MapBuilder should contain a Map, not extend one. Another possible design would be to use a single call with varargs: public class MapUtil { public static <K,V> Map<K,V> ...

IO: You use everywhere System.out.println and System.in (BTW, Scanner is much more convenient than a Reader). Even if you want to switch from console output to a simple Swing application with little ...

There is already a sum function: def totalCost = value + children.map(_.totalCost).sum

Why not throw in some arithmetics? private static String reverseInt(int i) { StringBuilder sb = new StringBuilder(); for(int d = i; d != 0; d /=10) { sb.append(d % 10); } ...

Yes, this code is hard to follow. Some thoughts: use generics, e.g. private List<String> prerequisites Provide useful constructors. E.g. Does a course without name make any sense? If not, the ...

You can avoid the special case for FizzBuzz No need to hard-code the limits It's not really bad if you have multiple returns in a short (!) method, but it should be avoided if you have an equally ...

Another version, using the Prelude function break. groupBy :: String -> Char -> [String] groupBy str delim = let (start, end) = break (== delim) str in start : if null end ...

Write your own class: class MyTextArea extends JTextArea{ private final List<Foo> list; MyTextArea(int row, int col, List<Foo> list) { super(row, col); this....

I would use a helper function, and I would avoid copying the array (using indices instead): public static int getLargest(int ... myArray) { return getLargest(myArray, 0, myArray.length); } ...

I don't think you can do anything about this. You have to cast here, and in the process you lose all information about the type parameter: The compiler can't know that if you have a RecursiveElement, ...

Not bad for a beginner, and I agree with Ben Aaronson's comments. Maybe not now, but when you progress, you should change some things: Break the code up in logical parts (here: methods), and every ...

Just a little remark as an addition to the other excellent answers: Don't repeat yourself, always try to to find an abstraction for common tasks. E.g. If you need to time methods, don't do it "...

Hmmm, not much ideas, only syntax: showResult :: (Int, Int, Int) -> String showResult (a, b, x) = concat [show a, "/", show b, " has ", show x, " exact digits"] preciseDivision :: Int -> Int -&...

That's how I would write it: import java.util.ArrayList; import java.util.List; public class SumsOfPerfectPowers { private final static int SIZE = 5000001; private final boolean[] result = ...

While everybody mentioned optimizing isPrime, nobody spotted the one glaring ineffiency: You can break the loop as soon as i*i > sum. Further you can skip the even divisors except 2: public static ...