# Tag Info

### Cardshifter game lobby

Well, there's lots of code needing review. I've done my best to split it into each language. I've avoided reviewing Angular, since it's a library I'm not comfortable with. HTML: You have tons and ...
• 5,603

### Cardshifter game lobby

Tables for layout This is a clear and obvious misuse of the table element. Tables are for representing tabular data and that's it. Would that same content make sense in a spreadsheet? If the ...
• 3,624

### Cardshifter game lobby

There's not much to cover, other than the things @IsmaelMiguel went over, nonetheless: The Mundane: This is less of a important thing, as a style thing, but: ...
• 11.8k
Accepted

### Cardshifter game lobby

Background: I work as a web developer at a company. I'm the only Angular guy here, and we are using Angular in our greenfield CRM project, so my answer will mainly address Angular (as no one else has ...
• 3,753

### Semantic markup for card blocks

200_success' comment is right, that the context and the content of the component is important for semantics. I assume, from the linked page, that you want to display a list of short articles that lead ...
• 2,164

### Cardshifter game lobby

You should use strict mode in your JS scripts. It will allow you to avoid a lot of common mistakes. See the section "Changes in strict mode" in the MDN article I linked. Some of the advantages of ...
Accepted

### Correct way to extend Bootstrap Modal - lock, unlock

Looks fine to me, except that you failed declare the e variable in the lock/unlock functions....
• 32.9k
Accepted

### Cover letter generator: guides writing a template and autofills information

First of all: be consistent. $("#blob").popover();$('#company_name').popover(); Mixed usage of single or double quotes is allowed in JS, but is sloppy. Use ...
• 2,030
Accepted

### FizzBuzzLizardSpock

Very nice. I can't really see any major issues here, just some nits to pick. Note, though, that my knowledge of Angular is near-nil, so perhaps there's something there that someone else will be better ...
• 32.9k

### Correct way to extend Bootstrap Modal - lock, unlock

Flambino did an excellent review, the only nitpick I have is that I would write ...
• 32.4k
Accepted

• 142k
Accepted

### Building a multi-panel display with React and Bootstrap

Move variables out of render All the variables you are storing are sitting in the render method of the respective component. ...
• 13.2k
Accepted

### Parking Lot Management System in JavaScript

Prefer const over let and var. When you declare a variable with ...
• 8,553
Accepted

### Toggle-item inside a Bootstrap dropdown-menu

It'd definitely be nice to get rid of the inlined style attributes. Since you've already ID'ed the sub-menu pretty extensively, it's pretty easy to add this to the ...
• 32.9k
Accepted

### Bootstrap Comment post HTML markup

About your HTML Removing all the div elements that seem to be needed only for presentation, you have this markup: ...
• 2,575

### "Pill" with thumbnail and link

The id attribute must to be unique per document. So I think that using ID for the cover image is wrong under the assumption that you may have many pills per page ...
• 16.4k
Accepted

### My minesweeper implementation in Javascript

Here are my personal thoughts: Naming: it's probably better to have placeBombs instead of initBombs, because you have a ...
• 2,785

### Single page site with navigation bar

You should add <meta http-equiv="X-UA-Compatible" content="IE=edge"> <meta name="viewport" content="width=device-width, initial-scale=1"> to your <...
• 141
Accepted

### Display and search through a JSON's items in Vue.js

Overall the code looks fine. There aren't any drastic changes I would advise - just mostly a few simplifications. As far as the design goes it looks good, though it may be wise to add a spinner icon ...
• 24.7k

Timestamp Why do you insert an invalid value '0000-00-00 00:00:00' into your TIMESTAMP columns by ...
• 20.3k

What I found the most "clean" solution is to use Bootstraps data-toggle, the trick is to add .in to ...
• 31

The answer suggested by jmel1 caused problems for me. Everything is fine when the menu was in a "collapsible" state, i.e. on narrow pages. However, on wide pages, it seemed to cause glitches in the ...
Accepted

Actually, there's sort of a built in way to do this. Just attach a click handler to the links in your .navbar-nav and call the collapse hide method on the navbar-collapse class: ...
• 156
Accepted

### Cleaning up a dining hall...website

From a once over, DRY (Dont' Repeat Yourself) You have a number of these blocks that seem all copy pasted: ...
• 32.4k

Don't remove the indentation inside of code blocks so that the code is on the same line as the signature. It makes the code harder to read as it's hard to piece together which ...
• 13.2k
Accepted

### Offline Euler problem viewer (text only)

This is too big for a comment, but I have reason to believe your links are not working. A random example, challenge 54: ...
• 12.6k
Accepted

### HTML5 markup for blog article

Just scratching the surface of the html code. Bear in mind it's difficult to review html since we are not focusing on the CSS and Javascript sections . Since am a Bootstrap fan most of my comments are ...
• 2,420

Huge problem You have 1 HUGE problem in your code: If you enter correct captcha - the form is sent. Doesn't matter if it passed validation or not. It is a logic error in your post processing. You ...
• 131

### Bootstrap file input styler

Function('return this')() It took two minutes to me to understand what it does. Let's see what it does step by step ...
• 2,956

Only top scored, non community-wiki answers of a minimum length are eligible