14 votes

Cardshifter game lobby

Well, there's lots of code needing review. I've done my best to split it into each language. I've avoided reviewing Angular, since it's a library I'm not comfortable with. HTML: You have tons and ...
user avatar
14 votes

Cardshifter game lobby

Tables for layout This is a clear and obvious misuse of the table element. Tables are for representing tabular data and that's it. Would that same content make sense in a spreadsheet? If the ...
user avatar
  • 3,624
13 votes

Cardshifter game lobby

There's not much to cover, other than the things @IsmaelMiguel went over, nonetheless: The Mundane: This is less of a important thing, as a style thing, but: ...
user avatar
  • 11.8k
13 votes
Accepted

Cardshifter game lobby

Background: I work as a web developer at a company. I'm the only Angular guy here, and we are using Angular in our greenfield CRM project, so my answer will mainly address Angular (as no one else has ...
user avatar
  • 3,753
11 votes

Semantic markup for card blocks

200_success' comment is right, that the context and the content of the component is important for semantics. I assume, from the linked page, that you want to display a list of short articles that lead ...
user avatar
9 votes

Cardshifter game lobby

You should use strict mode in your JS scripts. It will allow you to avoid a lot of common mistakes. See the section "Changes in strict mode" in the MDN article I linked. Some of the advantages of ...
8 votes
Accepted

Correct way to extend Bootstrap Modal - lock, unlock

Looks fine to me, except that you failed declare the e variable in the lock/unlock functions....
user avatar
  • 32.9k
7 votes
Accepted

Cover letter generator: guides writing a template and autofills information

First of all: be consistent. $("#blob").popover(); $('#company_name').popover(); Mixed usage of single or double quotes is allowed in JS, but is sloppy. Use ...
user avatar
  • 2,030
6 votes
Accepted

FizzBuzzLizardSpock

Very nice. I can't really see any major issues here, just some nits to pick. Note, though, that my knowledge of Angular is near-nil, so perhaps there's something there that someone else will be better ...
user avatar
  • 32.9k
6 votes

Correct way to extend Bootstrap Modal - lock, unlock

Flambino did an excellent review, the only nitpick I have is that I would write ...
user avatar
  • 32.4k
5 votes
Accepted

Playing with colours

Loading jQuery twice You're loading both jquery.min.js and jquery-1.10.2.js. I assume that that is an unintentional mistake. ...
user avatar
5 votes
Accepted

Building a multi-panel display with React and Bootstrap

Move variables out of render All the variables you are storing are sitting in the render method of the respective component. ...
user avatar
  • 13.2k
5 votes
Accepted

Parking Lot Management System in JavaScript

Prefer const over let and var. When you declare a variable with ...
user avatar
4 votes
Accepted

Toggle-item inside a Bootstrap dropdown-menu

It'd definitely be nice to get rid of the inlined style attributes. Since you've already ID'ed the sub-menu pretty extensively, it's pretty easy to add this to the ...
user avatar
  • 32.9k
4 votes
Accepted

Bootstrap Comment post HTML markup

About your HTML Removing all the div elements that seem to be needed only for presentation, you have this markup: ...
user avatar
  • 2,575
4 votes

"Pill" with thumbnail and link

The id attribute must to be unique per document. So I think that using ID for the cover image is wrong under the assumption that you may have many pills per page ...
user avatar
  • 16.4k
4 votes
Accepted

My minesweeper implementation in Javascript

Here are my personal thoughts: Naming: it's probably better to have placeBombs instead of initBombs, because you have a ...
user avatar
  • 2,785
4 votes

Single page site with navigation bar

You should add <meta http-equiv="X-UA-Compatible" content="IE=edge"> <meta name="viewport" content="width=device-width, initial-scale=1"> to your <...
user avatar
4 votes
Accepted

Display and search through a JSON's items in Vue.js

Overall the code looks fine. There aren't any drastic changes I would advise - just mostly a few simplifications. As far as the design goes it looks good, though it may be wise to add a spinner icon ...
user avatar
3 votes

Dynamically load data into bootstrap accordion navigation bar

Timestamp Why do you insert an invalid value '0000-00-00 00:00:00' into your TIMESTAMP columns by ...
user avatar
  • 20.3k
3 votes

Twitter Bootstrap collapsing ONLY "phone view" navbar menu on click

What I found the most "clean" solution is to use Bootstraps data-toggle, the trick is to add .in to ...
user avatar
  • 31
3 votes

Twitter Bootstrap collapsing ONLY "phone view" navbar menu on click

The answer suggested by jmel1 caused problems for me. Everything is fine when the menu was in a "collapsible" state, i.e. on narrow pages. However, on wide pages, it seemed to cause glitches in the ...
user avatar
3 votes
Accepted

Twitter Bootstrap collapsing ONLY "phone view" navbar menu on click

Actually, there's sort of a built in way to do this. Just attach a click handler to the links in your .navbar-nav and call the collapse hide method on the navbar-collapse class: ...
user avatar
  • 156
3 votes
Accepted

Cleaning up a dining hall...website

From a once over, DRY (Dont' Repeat Yourself) You have a number of these blocks that seem all copy pasted: ...
user avatar
  • 32.4k
3 votes

Loading YouTube videos inside a bootstrap modal

Don't remove the indentation inside of code blocks so that the code is on the same line as the signature. It makes the code harder to read as it's hard to piece together which ...
user avatar
  • 13.2k
3 votes
Accepted

Offline Euler problem viewer (text only)

This is too big for a comment, but I have reason to believe your links are not working. A random example, challenge 54: ...
user avatar
  • 12.6k
3 votes
Accepted

HTML5 markup for blog article

Just scratching the surface of the html code. Bear in mind it's difficult to review html since we are not focusing on the CSS and Javascript sections . Since am a Bootstrap fan most of my comments are ...
user avatar
  • 2,420
3 votes

PHP contact form using PHPMailer and Google Recaptcha

Huge problem You have 1 HUGE problem in your code: If you enter correct captcha - the form is sent. Doesn't matter if it passed validation or not. It is a logic error in your post processing. You ...
user avatar
3 votes

Bootstrap file input styler

Function('return this')() It took two minutes to me to understand what it does. Let's see what it does step by step ...
user avatar
  • 2,956

Only top scored, non community-wiki answers of a minimum length are eligible