14 votes

To-do list in jQuery

Use CSS classes rather than inline styles. Instead of modifying the style of each TODO item, use CSS classes. This offloads the styling into a style sheet where it ...
user avatar
14 votes

ToDo List Program Efficiency

I see a number of things that may help you improve your code. Don't abuse using namespace std Putting using namespace std at ...
user avatar
  • 64.4k
11 votes
Accepted

Task manager with dependencies

About the manpage The manpage looks very nice! There's a few small improvements that could be made: Spelling: "decrescend" should be "decreasing". Some conflicting statements are ...
user avatar
  • 33.5k
10 votes

To-do list in jQuery

Redundant properties You have a few redundant properties. The margin on your 2nd body declaration is doing nothing because you haven't set a width. ...
user avatar
  • 3,624
9 votes

Event scheduler in C

Self-documenting code char h1 = { (e.hour / 10) + '0' }; // Extract the first digit and convert to char (if any, else 0) As you considered the division by ten ...
user avatar
  • 27.2k
8 votes
Accepted

Angular todo list

$scope.user = gon.current_user What's gon? I assume it's your authentication/session object with all the things the app needs ...
user avatar
  • 24.8k
7 votes

To-do list in jQuery

Lyle's Mug gave a nice answer regarding how to improve the JavaScript overall. I'd like to instead look at the HTML: Don't put an input inside a heading. HTML elements have meaning, and an ...
user avatar
  • 32.9k
7 votes

To-do list in jQuery

3 things Comments Consistency Fewer new lines We all know that this is the Enter Key, but you should give a comment why you are using a Magic Number here ...
user avatar
  • 28.5k
7 votes
Accepted

Todo-list practice code accepts title and list

Your code looks nice and is properly formatted. Still, a few points could be improved. Magic methods As mentionned in ChrisWue's nice answer, the __str__ magic ...
user avatar
  • 28.7k
7 votes

Task manager with dependencies

agenda->htab = ecalloc(NHASH, sizeof(*(agenda->htab))); GCC's static analyzer can't find a corresponding call to ...
user avatar
6 votes

Event scheduler in C

Even though @Herickson already made most of the points but one thing he kindly left for me to note: strlen(3) returns the type ...
user avatar
6 votes

To-do list in jQuery

This will be my first review, so bare with me. I'm going to step though every function: First, I'd start with saving the reference to the todoList. This way, you only call it once and can use it ...
user avatar
  • 752
6 votes
Accepted

To-Do List in React

return { tasks:tasks, numCompleted:null } numCompleted isn't being used anywhere. Remove if from the data. Also, it's ...
user avatar
  • 24.8k
5 votes
Accepted

Simple todo list

Don't pollute the global namespace. You have 1 variable and 3 functions all going into the global namespace. This is especially a problem because of the generic names you have. So they could be ...
user avatar
  • 1,042
5 votes

To do tree application with undo/redo functionality

From your answer to my comment, I will drop the intended Python 3 paragraph (even though there are some goodies you may like in the most recent versions, such as the new ...
user avatar
  • 19.9k
5 votes

Basic ToDo App in Objective-C

There are a lot of things wrong here that I'm probably not mentioning at all. There is so much code that I instead want to focus on the big picture problems and the repeated problems (that you need ...
user avatar
  • 25.2k
5 votes

Event scheduler in C

A minor point, though it has the potential to get you into trouble: From the GCC manual section 1.3.3 - Reserved Names: reserved names include all external identifiers (global functions and ...
user avatar
5 votes

ToDo List Program Efficiency

Just a few more comments I haven't seen anybody mention. Avoid magic constants An obvious example would be: cout << "\033[2J\033[1;1H";. If you're going to ...
user avatar
  • 33.2k
5 votes
Accepted

Vanilla JavaScript to-do list

Your "clear" button To get your clear button to work, you just need to add the event listener to each button as its created, rather than at page load. To do that, take out your ...
user avatar
  • 230
5 votes
Accepted

TODO in React w/ Redux

I'm not exactly sure of your environment (I'm going to assume you're using Node), and with this assumption, I want to address a few things starting with specific things, then more general: Specific ...
user avatar
  • 261
5 votes

Simple front end TODO list

I have several comments about styling: check the indentation and fix it. There are some different styles that can be observed but universally lines that are inside a function (or even more generally -...
user avatar
  • 445
4 votes
Accepted

A small "TODO" app built using a modular pattern

There's some stuff that's confusing in this coding and it's structure. A few things of note: First when defining a class you do not need the beginning ( and ending ...
user avatar
  • 194
4 votes

TODO app in Kotlin

Here are some recommendations: Use if as expression when it's appropriate. var done = "" if (isDone) { done = "X" } The better way is to write: ...
user avatar
  • 136
4 votes
Accepted

Command line todo list manager

Your program expects the user to refer to completed or incomplete tasks by a numeric index. However, the Markdown file contains an unnumbered bulleted list, which forces the user to count the items ...
user avatar
4 votes
Accepted

Passing a callback to a component in Vue.js

Your question so I've passed a callback to it. Is this okay in Vue or is there any other preferred way of structuring things like this? If you haven't already, I would suggest you read the VueJS ...
user avatar
3 votes

To-Do List in React

I can't offer a full review for you right now, but here are a couple little things: A couple simplifications In ToDoContainer.render, this: ...
user avatar
  • 2,738
3 votes
Accepted

Native JavaScript to-do list app using Jade

I'll dissect your JS from top to bottom. But first, the overarching stuff: you tagged this question with OOP, but it's not taking advantage of OOP. It would be very natural to have ...
user avatar
  • 3,595
3 votes
Accepted

Should I declare all of the outer functions inside the object literal?

Two things: Don't use functions before you define them. Yes, this works fine with function declarations, but still it's a bad practise that disrupts the reading flow. Don't use global variables. All ...
user avatar
  • 1,547
3 votes
Accepted

Simple todo application

From a quick once over: Your first line creates an anonymous function, it offers you the opportunity to pick a great function name that conveys to the reader what he is about to be exposed to like <...
user avatar
  • 32.5k

Only top scored, non community-wiki answers of a minimum length are eligible