New answers tagged

3 votes

ASHv2 implementation from scratch - host, transmitter and listener

Strengths and Positive Aspects Clear Structure and Conciseness Your code exhibits a well-defined structure, aligning with the layered architecture described on page 3 of the UG101 UART-EZSP Gateway ...
Łukasz D. Tulikowski's user avatar
1 vote
Accepted

Basic rust Celsius to Fahrenheit conversion

I don't think there is too much to simplify. Note that we generally would err towards readable code rather than concise code. Or at least that was what I was used to as Java coder. Actually I'd ...
Maarten Bodewes's user avatar
3 votes
Accepted

Rust Wake-on-LAN CLI

The code looks very good to me. My suggestions are more opinion than anything else. You don't use the resolve-path crate. In your program it doesn't matter since ...
Sebastian Redl's user avatar
2 votes
Accepted

Sand simulation in Rust

deltas vs absolute pub struct Cell { ... has_been_updated: bool, That attribute seems less convenient than it could be. We iterate through an unbounded ...
J_H's user avatar
  • 25.5k
1 vote

Rust publish/subscribe channel library

I've found your crate looking for existing pub-sub solutions. Time has passed and there is now a good choice. async-broadcast lists a few. Review their comparisons to others. There are some situations ...
Robert Cutajar's user avatar
5 votes

Parse two-digit numbers from text

Looking good Your code is looking pretty good. Nice to see tests, notably. Documentation? Your code could do with some documentation. Simplifying Match The simple answer here is NOT to use ...
Matthieu M.'s user avatar
  • 5,137
2 votes

Parsing command line arguments with CLI

General The code is well laid out, and there is a clear separation of responsibilities between the various functions. This makes it easy to review, thanks! Documentation? There is no documentation, no ...
Matthieu M.'s user avatar
  • 5,137
3 votes

Rust: Command line menu in ASCII table

The String Table In this program, all your strings are constants, so you could store them as a const array: ...
Davislor's user avatar
  • 7,371
5 votes
Accepted

Simple Redis implementation in Rust

Don’t Panic! (On Runtime Errors) I admit I’ve sometimes put an .expect() or .unwrap() in my code examples, for simplicity. But ...
Davislor's user avatar
  • 7,371

Top 50 recent answers are included