Hot answers tagged

2

I can only review the JS part, I am not sure that grammar reviews are part of CR. collapse else branches after a return do not make sense. I would propose map/join instead of reduce/concat Something likes this: function collapse(stuff) { if (typeof stuff === "string") return stuff; if (stuff instanceof Array) return stuff.map(...


1

This code looks pretty solid. It utilizes many ecmascript-6 features like arrow functions, default parameter values, const for any value that doesn't get re-assigned and let for values that can be re-assigned, etc. Comments could be added to help document the code. Some of the trivial functions could be simplified - e.g. function value(v) { return () =&...


Only top voted, non community-wiki answers of a minimum length are eligible