Skip to main content

New answers tagged

6 votes

Rules-engine to be improved/simplified for Efficiency (performance), Extensibility and Maintenance?

auto() Idiomatic use of auto() in ConditionKind is very nice. Repeating FOO and NOT_FOO seemed odd. It looks like we want a (...
J_H's user avatar
  • 29.3k
4 votes

Calculation of centrifugal liquid propellant injectors

Even without understanding the matter at hand, or the algos involved, if we look at it purely from a programming view point I believe some properties could be consolidated. A function can return more ...
Kate's user avatar
  • 6,983
5 votes

Calculation of centrifugal liquid propellant injectors

First of all: thank you! This code is in good shape overall, I wish everything I work with could look like this. Now, a few more comments to complement @J_H answer: Enum? String? You define a ...
SUTerliakov's user avatar
7 votes
Accepted

Calculation of centrifugal liquid propellant injectors

Thank you for citing a reference. worth dividing ... by type of construction The code is quite readable as it is. But we have 26 derived properties, so yes, if you can break out a couple of ...
J_H's user avatar
  • 29.3k

Top 50 recent answers are included