3
I only have some comments about the shell scripting elements.
This is a very archaic (and silly) way of testing flags:
[test "x$enable_yaml" != "xno"],
You can write simpler as:
[test "$enable_yaml" != no],
This can be simplified:
if test "${with_yamlroot}" != ""; then
To just:
if test "${with_yamlroot}"; then
I also find it odd to ...
answered Feb 15 '15 at 10:30
Stop ongoing harm to Monica
104k13 gold badges137 silver badges360 bronze badges
2
The main M4 file
Should I pull the setup script into this macros or leave it separate?
I think it's good you separated.
For the same reason that it's good to decompose a large function doing many things to smaller functions.
If it doesn't make sense to ever run the setup script independently,
then an alternative is to put it in a function,
if that's ...
answered Feb 9 '15 at 7:10
Stop ongoing harm to Monica
104k13 gold badges137 silver badges360 bronze badges
Only top voted, non community-wiki answers of a minimum length are eligible
