New answers tagged

3

While formatting is a matter of preference, you shouldn't stray too far away from common ground. Consider moving your opening and closing brackets back, so: int main() { return 0; } instead of int main() { return 0; } Message_type Make a stand, either CamelCase or snake_case, not some weird offspring. while (running) ...


0

FYI - I'm a bit rusty with PHP and not a PHP expert in anyways. TL;DR Be strict on coding style and standard. Clean the class responsibility, implement (at least) Single Responsibility Principle. Make smaller functions. Write Unit test. Retrospect Use Strict! This generated a lot of errors that was not there before. <?php declare(strict_types=1); ...


1

Initial feedback This code looks okay, though has quite a bit of room for improvement - see this suggestions below. I like how the short array syntax is used in many places, as well as type hinting of parameters and return types for methods. Some methods are a bit lengthy and a bit of an eyesore - e.g. the method EvaluateVariable- its more than 100 lines of ...


2

Standards private function AnalysisVariable(string $varname, $var, array $indents): string So there are a couple problems here. In the text of your question, you refer to this as AnalVariable. That's a particularly bad name as anal is an English word that is somewhat off-color. Fortunately changed here. PSR-1 says that method names should be ...


Top 50 recent answers are included