4

The obvious problems to me are: You are not using your function's parameter. You are using scanf. You are using recursion where you should not use recursion. You are mixing several different concerns (node creation, list organization, user input, input validation). You are not handling errors. Using your function's parameter Since you don't use the ...


4

There is a small typo in this line: typdef struct lista { It should be typedef struct lista { I ran sig through Google translate and it came up with Mr. Not very helpful, so I'm asuming the sig means next :-) I used the following main function to confirm that it's working: int main() { nodoNum* root = crearLista(0); for (nodoNum* nodo = root; nodo;...


4

A few things to consider... Naming Naming is important, code is read a lot more than it is written and anything that makes the code easier to read helps. One element of that is consistency, which is something that your test names don't have. Some of them start with test and some of them don't. Some of them are quite descriptive about what's being tested ...


3

There's a lot of scope for consolidating the benchmark code. Reducing some of the duplication can make it easier to update the code and help focus on core functionality of some of the methods. With that in mind, here's a few suggested refactorings... A List is a List You've got four lists of different types, all with their own variables, that are declared as ...


Only top voted, non community-wiki answers of a minimum length are eligible