29 votes
Accepted

Python - Tkinter - periodic table of chemical elements

I hope you enjoy this bit of code. I did! Your symbols, keywords and values should have capitalised variable names since they're global constants. However, life would be easier if your symbols were ...
Reinderien's user avatar
27 votes

Python - Tkinter - periodic table of chemical elements

Don't optimize the wrong thing You have an excellent review already, so I'll comment on a narrow topic: cramped code layout. For example: ...
FMc's user avatar
  • 12.7k
24 votes
Accepted

2048 with GUI in C

Well done. This is not a complete review, but instead a (short) list of possible improvements I found when I skimmed your code. Documentation First of all: thank you! It's great to have ...
Zeta's user avatar
  • 19.3k
10 votes

A GUI Youtube Player (2)

Thanks for bravely offering up your code. I'm sure it will emerge in better shape. Each development project has its own standards. If they aren't written down in the ReadMe, then we tend to assume ...
J_H's user avatar
  • 25k
9 votes
Accepted

C++ "Dear ImGui" file browser

One of the things I'm specifically wondering, is it ok/proper to have static helper functions in the .cpp file if they are not member functions? (should they be member functions and should they even ...
JDługosz's user avatar
  • 11.3k
7 votes

Showing object's data on GUI and HTML without accessors and mutable objects

Your outset is wrong. The articles you've linked to present a nice story, but what you're running into here is the issue with that ideology: When your data structures AND your views are rigid, you ...
Pimgd's user avatar
  • 22.3k
7 votes
Accepted

Login UI for an Android app

Using an AsyncTask instead would be much better. You've got many callbacks to the UI thread, all of this you could do in the post execute method instead: ...
Aritz's user avatar
  • 355
7 votes
Accepted

Handling dialog closure in a VBA user form

I like how your form is no longer concerned with anything other than being a form. One More Abstraction Level I'd go one step further, and encapsulate the controls, so that the presenter class doesn'...
Mathieu Guindon's user avatar
6 votes
Accepted

A little advanced mouse clicker in Bash for Linux

Use $((...)) instead of $[...] The $[...] syntax is obsolete. Use ...
janos's user avatar
  • 111k
6 votes
Accepted

AppJar number pad and keyboard

Python has an official style guide, PEP8. It won't hurt getting familiar with it, since it helps keeping your code readable, consistent and ready for others to mess with. Combining Italian and ...
Mast's user avatar
  • 13.4k
5 votes
Accepted

Populate Comboboxes with Hashtables using PowerShell

The first thing to observe is that the five pieces of code are identical except for two parameters that are varying. We can capture the common the code in a function (let's call it ...
Dangph's user avatar
  • 1,683
5 votes
Accepted

Displaying an arbitrary number of buttons and automatically arranging the buttons

Don't import tkinter twice You're doing this: import tkinter as tk from tkinter import * Remove the second import since you are already importing tkinter. That ...
Bryan Oakley's user avatar
  • 2,089
5 votes

GUI Number Generator in QT C++

I see a number of things that may help you improve your program. Use proper case for file names We all know that Windows is not case sensitive with respect to file names, but pretty much every other ...
Edward's user avatar
  • 66.4k
5 votes
Accepted

Qt Number Generator v2

Seems like you've made a lot of improvements since your previous post! Let's get into the review! 1. General Overview a. Use the ...
TrebledJ's user avatar
  • 437
5 votes
Accepted

GUI to organize images, chapter titles, animation steps, and instructions

If there's a list, make it a list Do not represent RxCx variables as separate variables. Represent them as nested lists and it will greatly simplify your code. ...
Reinderien's user avatar
5 votes
Accepted

College Billing System - Java

Absolute positioning This: l1.setBounds(550, 100, 250, 20); and lines like it are non-ideal. Absolute positioning will fail to scale the controls and their ...
Reinderien's user avatar
5 votes
Accepted

Python PyQt6 populate QTreeWidget with a list of named tuples

You have a pile of unstructured, global code; this needs to be organized into functions and maybe classes Close your cursor once you're done with it, ideally via context management Order your query ...
Reinderien's user avatar
4 votes
Accepted

Extremely Simple Paint Program in Java

Your code formatting deviates from the default Java code formatting, just saying. import java.awt.*; import java.awt.event.*; import javax.swing.*; Wildcard ...
Bobby's user avatar
  • 7,722
4 votes

Showing object's data on GUI and HTML without accessors and mutable objects

In addition to Pimgd's excellent review: Use StringBuilder to build strings String concatenation by operator + causes many ...
Emily L.'s user avatar
  • 16.6k
4 votes

Application for encrypting and decrypting files in Java - follow-up

private boolean graphicalInterfaceRequested; private boolean printHelpMessage; private Mode mode; private int key; private String[] args; These most probaby ...
Vogel612's user avatar
  • 25.2k
4 votes
Accepted

Application for encrypting and decrypting files in Java

Specifying a key From a UX perspective, I think it will help if you can also indicate that the key should either be prefixed with 0x, so that you will treat it as ...
h.j.k.'s user avatar
  • 19.2k
4 votes

"I'm Listening"

There is only one thing that I could point out: you are relying on the label of the button to determine whether it is "on" or "off". Instead, it would be better to introduce a ...
Tunaki's user avatar
  • 9,243
4 votes
Accepted

Custom GUI Slider class

Looks pretty neat. I only have a couple comments: At first I was puzzled by those __SOMETHING macros, then I looked into your repo and they are actually aliasing a ...
glampert's user avatar
  • 17.1k
4 votes

Minimal spreadsheet program

is_reference The possibility of an IndexError can be mostly eliminated by reordering the conditions: ...
janos's user avatar
  • 111k
4 votes

Minimal spreadsheet program

The code looks okayish so my point are mostly about code style and preferences, you might easily ignore any if you prefer a different coding style. Apart form things that @janos mentioned: 1....
Alex's user avatar
  • 1,622
4 votes
Accepted

My first Qt application - a multiple-state window with a menu

That's a good first Qt program. Most of my comments are preferences rather than rules, but I'll try to provide justifications. In main(), no need to ...
Toby Speight's user avatar
4 votes
Accepted

GUI Application for counting visitors

Personally, when building GUI applications I like to wrap my code into a class, and handle each action into each own method. I'll start from top to bottom. I don't use wildcard ...
Grajdeanu Alex's user avatar

Only top scored, non community-wiki answers of a minimum length are eligible