Skip to main content
Share Your Experience: Take the 2024 Developer Survey
7 votes

CAT: Cat Approved TUIs

You appear to be asking for a review the part of the code you posted, not the library itself. (ETA: I wrote this before you posted any of the library code.) I’m not sure how useful that will be, but ...
Davislor's user avatar
  • 7,546
6 votes

Building a simple ORM in PHP

One thing I believe is obvious is that your ORM is subject to SQL injection unless I am missing something. For example, in my understanding, you could make something like this ...
Carlos's user avatar
  • 61
6 votes

CAT: Cat Approved TUIs

Unfortunately you've only shown some of the header files, but no concrete implementation of your TUI library, so I cannot meaningfully review that. However, we can look at your intended use of the TUI....
G. Sliepen's user avatar
6 votes

CPU emulation library

What the.. You have the following ...
Blindman67's user avatar
  • 22.1k
5 votes
Accepted

Undo Framework Design (Revert the changes in the collection)

Edge cases This fails to handle several edge-cases: Undoing a remove action multiple times results in that item being added back multiple times. Undoing an update action after other items have been ...
Pieter Witvoet's user avatar
5 votes
Accepted

Html rendering framework with dynamics

This looks really weird: ...
Nikita B's user avatar
  • 13k
4 votes
Accepted

Web Development DSL

Things you've done well There's a lot to like here. This is good code, easy to read and understand. I especially like: Comments Standard formatting (two-space indent, etc.) Short methods A little ...
Wayne Conrad's user avatar
  • 3,274
4 votes
Accepted

Bitex - Cryptocurrency Exchange API Framework for Python - Round 2

There's a lot of code here, so I'm just going to review bitex.api. You'll see that there's plenty here for one review. Maybe some of the other reviewers here at ...
Gareth Rees's user avatar
  • 49.6k
4 votes
Accepted

Database abstraction layer for multiple providers

DbProvider<TConnection, TCommand, TData> In the ExecuteNonQuery() method you are doing stuff before you check the passed ...
Heslacher's user avatar
  • 50.4k
4 votes

Simple object validator with a new API

As developer consuming your API .. Usability I find this a verbose way of constructing validation rules. ...
dfhwze's user avatar
  • 13.9k
4 votes

Manifest.JS: A lightweight front-end structural framework

From a short review; isCyclic -> I would consider throwing obj into JSON.stringify and ...
konijn's user avatar
  • 33.2k
3 votes

Building a simple ORM in PHP

I am particularly interested in how ORMs really work, but not succeeded with writing an exemplary mapper yet. So I am really interested in your approach, which is quite good to my taste, save for ...
Your Common Sense's user avatar
3 votes
Accepted

Functional Html builder

NonEmptyOrNull() the name is ambiguous. Is it !empty || null or is it !(empty or null)? ...
Nikita B's user avatar
  • 13k
3 votes

Simple JavaScript front-end framework for building web components

You, my friend, are an architecture astronaut. Holy moley, dude, 110 lines of code on top of 4 libraries to do something that would take a couple dozen lines of code to do in "vanilla" JS sounds to me ...
I wrestled a bear once.'s user avatar
3 votes
Accepted

Type converter framework (v2)

Thanks for sharing – it is an interesting problem :) I would go with mutable state only when it is required for performance optimization. Immutability almost always makes code a way cleaner and ...
Dmitry Nogin's user avatar
  • 6,131
3 votes
Accepted

Adjusting business logic conveniently through JSON and expression trees

I think there's a lot of room for improvement here. The 'syntax' could be made less verbose and extending the system could be made easier with a better selection of core expressions, among other ...
Pieter Witvoet's user avatar
3 votes

Mockingbird c++ mocking framework

You make the code really hard to read: ...
Martin York's user avatar
  • 95.2k
2 votes

Type creator service & framework

It does not sound like Type creation for me… We are not generating code at run time here. What we deal here with is just a set of converters, which is solvable ...
Dmitry Nogin's user avatar
  • 6,131
2 votes

Basic MVC Framework

View: Possible Bug / Security Issue The assign method of the View class sets arbitrary fields. The problem here is that you ...
tim's user avatar
  • 25.1k
2 votes
Accepted

Telegram Rest API client design

You are right, the code looks messy. Here are some hints that concern only the fragments listed in the question (I looked briefly inside the project repo, but it's too huge to analyze here). ...
Antot's user avatar
  • 3,657
2 votes
Accepted

Genetic algorithm implementation

You can make your code shorter and more readable with LINQ. This: int[] arrayD = new int[total]; for (int a = 0; a < total; a++) { arrayD[a] = a + 1; } ...
Risky Martin's user avatar
  • 1,611
2 votes

Html rendering framework with dynamics

To be honest, there isn't enough to refactor here as your code looks clean but I notice in your constructors you've this: ...
Tolani's user avatar
  • 2,465
2 votes

JavaScript modular framework for a large web-site

Very readable code, some minor comments: Some folks dislike the lacking curly braces for one liners, I dont mind it here myself JsHint will complain about you creating a function in a ...
konijn's user avatar
  • 33.2k
2 votes
Accepted

Learning PHP MVC: bootstrapping and front-controller

I would say you are generally on the right track but have some mixed responsibilities: there are some things in the front-controller that belong to the bootstrapping and some things in the front-...
Conor Mancone's user avatar
2 votes
Accepted

Simple JavaScript front-end framework for building web components

I like what you've created. If your main goal was to build a simple template for organizing component code and getting a handle on a pile of legacy code, then I think you've accomplished that goal. It ...
Randall444's user avatar
2 votes

Simple object validator with a new API

(self-answer) Simplified the API You were right, the API was too verbose so I drastically simplified it. It now presents itself like that: ...
t3chb0t's user avatar
  • 44.3k
2 votes
Accepted

Database interface and PDO adapter

That's a pretty solid implementation, with many possible issues already solved. However, there is room for improvement still. Here is a brief list: Yes, you are absolutely right, a db wrapper must ...
Your Common Sense's user avatar
2 votes
Accepted

Adding more functionality to tkinter for projects (Revised)

Some improvement, but there's still more :) Don't semicolon-delimit statements self.window = super(); self.window.__init__() There's nearly never a good reason ...
Reinderien's user avatar
  • 62.1k
2 votes

Manifest.JS: A lightweight front-end structural framework

Big picture overview Limit scope to a big-picture overview, which should help save time since it is a good sized chunk of code for one review. While I plugged the modules into a plunker, it is still ...
Sᴀᴍ Onᴇᴌᴀ's user avatar

Only top scored, non community-wiki answers of a minimum length are eligible