Skip to main content
7 votes
Accepted

C++20 Coroutine Generator

Minor compile issues Not all compilers support coroutines fully yet, and at least on GCC 10 your generator fails to compile, because: ...
G. Sliepen's user avatar
  • 58.3k
5 votes

C++20 Coroutine Generator

Don't do using namespace std; it can lead to name collisions and other issues. (It looks like it's only being used for cout and <...
user673679's user avatar
  • 11.8k
4 votes

Single threaded epoll based coroutine library for C++, Linux

I was very interested in reviewing this code, because it would be the first time I’ve reviewed any code with coroutines. Unfortunately, I just couldn’t get through it. There is so much code, and it is ...
indi's user avatar
  • 11.4k
3 votes

Small coroutine class

I think you need to document your assumptions and/or intended use cases a little better. Right now, I don't see how anything based on setjmp/...
Quuxplusone's user avatar
  • 19.4k
3 votes

Correct flow between Kotlin, Realm and ViewModels using Coroutines

I like your architecture decomposition. Especially separation of model and realm object. From what I see it is correct and quite clean. One thing to consider is to keep using ...
K.H.'s user avatar
  • 2,668
3 votes
Accepted

sendmsg() scatter-gather coroutine awaiter, optimized suspending

Simplify your code Parts of your code are more verbose than necessary, especially when using newer C++ versions. For example, I would write: ...
G. Sliepen's user avatar
  • 58.3k
2 votes

Kotlin Compose authentication with Google and Facebook using a CircularProgressIndicator for UI loading

First, GoogleSignIn is deprecated. You now have to use Credential Manager. That being said... I recommend you to move all login logic to the ViewModel or data layer:...
Peter Araujo's user avatar
2 votes

C++20 Coroutine Task

@Louis-Langholtz This has been a while, but I certainly can do that. After running a first attempt at fixing @rafoo's code, I've understood the real source of his code's problem. It does a ...
Michel's user avatar
  • 121
2 votes
Accepted

Finding files using multiple coroutines

OK, there's a number of things I'd change about your code. I'll go through what you posted, making suggestions based on what you have already, then I'll make some additional suggestions. ...
Elias Van Ootegem's user avatar
1 vote

Finding files using multiple coroutines

Is there anything wrong with this code or what needs to be improved? Yes. Read the documentation. package io/ioutil func ReadDir(dirname string) ([]fs.FileInfo, error) As of Go 1.16, os.ReadDir is a ...
peterSO's user avatar
  • 3,531
1 vote

Getting a value with timeout using Kotlin coroutines

Think it's pretty good and you can't think of much else. Some tiny bits I can think of: Make discoveryService parameter. Do not use ...
K.H.'s user avatar
  • 2,668

Only top scored, non community-wiki answers of a minimum length are eligible