108
votes
Accepted
How clean is my snow?
Let's look at the code.
from random import randrange
import time
Your imports are very minimal! Good.
...
- 3,574
61
votes
How clean is my snow?
Cool animation!
Let's get some linting out of the way. As per PEP 8, you should use 4 spaces of indentation consistently, and function names should be snake_case.
...
- 144k
37
votes
34
votes
Accepted
Rock, Paper, Scissors in C++
It's a good start! Here are some things that may help you improve your program.
Don't abuse using namespace std
Putting ...
- 65.3k
33
votes
Accepted
Loading... animating dots in C
Too frenetic
I ran your program but it was very frenetic. It was constantly clearing the "Loading" prompt and reprinting it which resulted in a flickering effect. In addition, the cursor also moved ...
- 28.5k
31
votes
Accepted
"Compliment giver" mini-program
Don't be discouraged by how much I have written. I'm a professional software developer and my colleagues make fun of me because of how pedantic my code reviews are. I think what you've done is ...
- 406
30
votes
How clean is my snow?
I'm surprised no one has talked about your character choice! Why are their a bunch of hashtags falling? Nah, I kid, it was an ok choice of character, but we can do better! What about changing the <...
- 5,824
27
votes
Simple text-based RPG in Java
OOP
This task really begs for object oriented programming.
As a first step,
I suggest moving the maxhp, playerhp, ...
- 111k
24
votes
Dungeon Crawl game for the terminal
Overall, this is really well done. You've missed the usual traps of using magic numbers, not creating structures for related items, and other common things. So nice work! I think it could be improved ...
- 11.6k
22
votes
"Up" script for moving up directories quickly
This is a decent concept, but by looping on the cd you loose some of the value of the $OLDPWD function in the shell. For example,...
- 97.3k
22
votes
Accepted
pyCMD; a simple shell to run math and Python commands
The first thing I notice with your code is that the code is a very long global script. To resolve this I'd start by moving your code into functions.
The actual calculations could be as simple as say:
<...
- 42.7k
21
votes
How clean is my snow?
def createRandomDrops():
dropCount = 4
for i in range(dropCount):
Magic number 4 in middle of the code
...
- 311
21
votes
Accepted
List the movies I haven't seen
Welcome to codereview. Here are my suggestions:
Functional decomposition and Naming
The trickiest part of programming is to decouple your complex problem into smaller easier (sub)problems. It is ...
- 8,520
18
votes
Dungeon Crawl game for the terminal
That's an awesome little game!
User experience
Before we dive into the code, let's talk about the game itself.
Random hangs
Sometimes, the executable hangs when I ...
- 1,148
18
votes
Tic-Tac-Toe for the terminal
First of all: nice work! It's easy to read and understand.
Program organization
It's very good that you split the task to small functions.
Reading the body of main...
- 111k
18
votes
Recreating Minesweeper
Overall Impression
This code is not maintainable in its current state. Good code should always be maintainable.
Code Readability
The code is very difficult to read. This line of code in ...
- 23.5k
17
votes
Accepted
Design patterns for console commands
Why do you have the Command class? Why not make life much simpler for yourself by making AllCommands a ...
- 11.2k
17
votes
Accepted
Python command-line program that generates passwords
Put all code in functions. Code in functions can be tested, experimented
with, and reorganized much more easily than code floating around at the top
level. Floating code introduces the temptation to ...
- 12.5k
16
votes
Accepted
"Up" script for moving up directories quickly
Your recommendation is to define alias up=". path/to/up" so that when you type up 3, it expands to ...
- 144k
16
votes
Accepted
Progress Bar in C++
I wrote a simple main() function to test this:
int main()
{
show_progress_bar(100, "progress", '#');
}
I ...
- 72k
15
votes
Accepted
Minesweeper C++
C++ Vs C
As has been said in the comments, your code reads very much like it's been written in C. You're using C functions like printf instead of the more C++ <...
- 11.6k
14
votes
A top-like live monitor for virsh/kvm/qemu VM's
Subprocess
out, _ = subprocess.Popen(['virsh', command, arg], stdout=subprocess.PIPE, stderr=subprocess.STDOUT).communicate()
is a little clunky; consider
...
- 59k
14
votes
Accepted
Tic-Tac-Toe code using c#
Choosing good identifiers
When I see a name like options I think of something a player can choose from like "single player" (i.e., play against the ...
- 4,875
14
votes
Python command-line program that generates passwords
I feel like you came up with an over-engineered solution that, ultimately, fails to meet expectations.
Generating a password is a task with well-defined use-cases, that we encounter almost daily.
Most ...
- 3,004
13
votes
Accepted
Counting density of Python code
The docstrings are vague. Documentation needs to be precise and complete. It should answer questions like "what arguments should I pass?" and "what does it return?" For example, "go through the AST ...
- 49.6k
13
votes
Accepted
Console calculator for 2 numbers at a time
Some rules of thumb:
If you have your entire program in a single method (Main(), in this case), there are some design considerations you should probably revisit. ...
- 13.8k
12
votes
Accepted
Binary Bayes network classifier in Java - Part I/II
I like comments. I like Javadoc. But comments that say what are suspicious - good comments say why, not what. Given self-explanatory code, Javadoc on private members is overkill: you have Javadoc ...
- 75k
12
votes
Non-curses pager in C
Bug
You're code has a bug-ish. When using this, if instead of hitting enter when asked to enter a character you enter some other letter and then you press enter, then next newline will be skipped and ...
- 13.3k
12
votes
Accepted
Hexadecimal command line file viewer
If a program fails for some reason then it should
Write a diagnostic message to standard error (not standard output),
so that it can not be mistaken for normal output, e.g. when
the program runs in a ...
- 23.1k
Only top scored, non community-wiki answers of a minimum length are eligible