New answers tagged

2

In your current implementation you are caching the users in users field in UserManager, but this has a chance of data loss if there are multiple instances of the application is run and new user are created there. Password should always be hashed. Though I understand it is an internal app, this is a good practice to ensure anyone's password is not ...


3

I have some suggestions. MessageViewerProgram Instead of brute forcing all the messages in the directory, I suggest that you list them and iterate on them instead. You can use the method java.io.File#listFiles() for this. File file = new File(saveDir); File[] files = file.listFiles(); This will give you an array of the files in the message folder, and ...


2

I get that security isn't critical in this case, but it's probably still good to store the passwords in a hash. Some people may be using the same password for other websites and you don't want to compromise their security on those sites. There should be libraries to handle hashing passwords and it would be much better (and simpler) to use them than to try ...


Top 50 recent answers are included