Search Results

First, object_id is a built-in method of Object in Ruby, so I recommend renaming this field to model_id to avoid any clashes. …

def print_multiplication_table(max) I think size would be a better name for the argument. max sounds like it's the largest number in the table. pad = (1 + (max*max).to_s.length) Rename to col …

Time.zone.now.strftime('%V').to_i Use Date#cweek to get the calendar week number: Time.zone.now.to_date.cweek

Minesweeper in Ruby (from exercism.io): Write a program that adds the numbers to a minesweeper board. …

Place.send(params[:category]) Using raw user data with send is very dangerous, as it allows the user to call any method (params[:category] could be "delete_all" for example). Using raw user data w …

(In ruby you don't have to declare "instance variables / fields" to use them) Also, make all internal methods private so they are not accessible from outside the class. …

Suggested solution: #USAGE: <input source> | ruby debug_converter.rb <comment symbol> > <output file> raise "Wrong number of args: #{ARGV.inspect}" if ARGV.length ! …

Bug This: knight_moves([2,5],[2,5]) prints: Your path is: [2, 5] [4, 6] [2, 5] Not the shortest path. In knight_moves, simply call bfs with [first_child] as the children argument. There's no ne …

Bug Adding a user with a username that is already taken overwrites the existing user. Adding a user with a blank username is allowed. (Maybe you should allow alphanumeric characters only, and set a …

Your code looks good. I only found an edge case with rehash, missing functionality in fetch, and some minor fixes. h ? new_from_hash(h) : nil This can be written as: h && new_from_hash(h) def …

@bids = current_user.bids.select { |bid| bid.real_property_sale.try(:real_property_sale_project).try(:failed_date).nil? } if ... @bids = @bids.select { |bid| ... } elsif ... @bids = @bids.s …

class Array def chunk(chunk_size) self.each_with_index.with_object(Array.new(size / chunk_size) { [] }) do |(elt, ind), result| result[ind / chunk_size] << elt end end end You re …

I will review the Board class. def display_board puts "\e[H\e[2J" # ANSI clear @board.each_slice(3).with_index do |row, idx| print " #{row.join(' | ')}\n" puts ' ---+---+---' unless idx …

Not bad. Unbounded recursion Inside the Game class: def initialize # ... play_game end def play_game @player1 = Player.new("X") @player2 = Player.new("O") # ... play_again end def pl …

Don't put your method inside Kernel. Rename ls_grep to something more descriptive, e.g. unlock_spreadsheet. The two shell commands (cd and ls|grep) aren't needed. The code doesn't depend on the curre …