Search Results

First, you should give your variables names that are descriptive - Option Explicit Sub Previous_comments_and_modifications() Dim MainWB As Workbook Set MainWB = ActiveWorkbook Dim SapDataWS As Works …

I'm not sure what's happening on yours but with 10K rows it's doing 1 row per .000090625 seconds (<1 second total) - Sub test() Application.ScreenUpdating = False Dim i As Integer Dim firstrow As Int …

The first thing I'd say is your variable names could be improved - what is t? BeginningTicketCount? what is tt? EndingTicketCount? Index and Index2 - I'd avoid Index as system reserved and I'd avoid …

Using Verify might confused the reader as being an excel method or function. And if I understand correctly MakeUnique will make name if used, into name1? … If you need to explain it, explain why you're doing it this way rather than that way: 'Make sure the name is <= 255 characters could be 'Excel doesn't allow names longer than 255 characters By the way …

All right, I have some input here. First - your variables. I can't tell what they are for. I'd use Main Dim myWorkbook As Workbook Set myWorkbook = ThisWorkbook Dim cartWorksheet As Work …

I'm going to throw an answer out here as well. First things first, I agree with Mat's Mug about using codenames, but I'm going to leave it as is for my answer, out of simplicity. Same goes for indenta …

You use ActiveWorkbook.Sheets("Notes") 5 times, throw that into a variable or use CodeName property - View Properties window (F4) and the (Name) field can be used as the worksheet name. This way you c …

Is the naming too repetitive? Let's take a look at your variables Dim aggregatedSubsheetDataReport As CLS_Data_Report Dim clientInvestmentReport As CLS_Data_Report Dim commissionReport As CLS_Data_Re …

There's a good question on StackOverflow addressing this - https://stackoverflow.com/questions/10714251/how-to-avoid-using-select-in-excel-vba-macros . …

There's a good question on StackOverflow addressing this - https://stackoverflow.com/questions/10714251/how-to-avoid-using-select-in-excel-vba-macros . lastRow = Range("A1").End(xlDown).Row this isn't … a great way to do this, the standard way is lastRow = Cells(Rows.Count, 1).End(xlUp).Row - see this answer on SO by a very talented excel MVP Everything you're doing on the sheet can be done in the code …

Your naming isn't great, you should use variable names to describe what they do Dim i As Integer Dim j As Integer Dim mapToFill As Range Dim legend As Range Dim targetDestination As Range Dim target …

To speed it up, I would read it into arrays. One array for column A and one array for column B and then combine them into another array and print that to sheet Option Explicit Sub Rearrange() Dim …

There's a good question on StackOverflow addressing this - https://stackoverflow.com/questions/10714251/how-to-avoid-using-select-in-excel-vba-macros. …

I'm going to address your use of constants - I don't think they are helping you very much. Most of them are just constant numbers, yes, but when I go to any of your private subs - I have no idea what …

You didn't declare y or x. Always turn on Option Explicit. You can have it automatically by going to Tools -> Options in the VBE and checking the Require Variable Declaration option. This way if you …