Search Results

Unfortunately the code doesn't compile - perhaps you have some non-portable assumptions? gcc-14 -std=c23 -fPIC -gdwarf-4 -g -Wall -Wextra -Wwrite-strings -Wno-parentheses -Wpedantic -Warray-bounds -Wm …

I'm also surprised that we couldn't write the optimistic parsing without longjmp() (which most of us avoid because it complicates reasoning about program state). …

This is clear, well-presented code; much better than the thrown-together hacks often seen as programming-challenge entries. We could perhaps make it even clearer by giving a name to std::function<std: …

Instead of parsing a double with restrictions, it may be simpler to read 1 or 2 integers separated by . and treat the result as a rational number. …

It would be better if we could pass a locale object to control which parsing rules are used, but that would obviously inhibit constexpr evaluation. … Perhaps we should wholeheartedly jump to the C locale and use our own digit predicate: constexpr bool is_digit(char c) noexcept { return '0' <= c && c <= '9'; } We're constrained to parsing …

We're missing includes of <locale> and <limits>. It is not portable to assume any transitive includes of standard library headers except those few specifically prescribed in the C++ standard. This lo …

Prefer <cstring> to <string.h> The C compatibility headers should only be used for extern "C" interfaces. For C++ programs, use the C++ headers, which definitely declare identifiers in the std namesp …

It's normal to write main() as the last function, so there's no need to forward-declare getDigts(). We would normally make that function static unless there's a good reason to share it with other tra …

Everything Edward said; plus some code-level review: union __int_m_data{ Use of double underscore within an identifier is dangerous. Such names are reserved to the implementation for any purpose ( …

Ooh, unit tests! You know how to make me happy! Let's look at the tests first, as that's valuable documentation of the expected use cases. A purist might argue that these are not unit tests because t …

Some style critique from me (the principles seem sound). Since the standard headers are independent of each other, we can include them in a consistent order. I prefer alphabetical, but you could choo …

I think that's the wrong choice, as conceptually, joining continuation lines is usually the first step in parsing. In either case, we should document this in comments. …

If user code is not supposed to access the innards of a reapMapIterator, it's best to make it an incomplete type in the header, and define it only in the implementation. A small change is needed to t …

I'm not a Javascript programmer, but it looks strange that we return a different type of result for the default case. Can't we return a number (e.g. 0)? Or a NaN? Or perhaps even throw an exception. …

Naming C reserves identifiers beginning with _ followed by any letter for the implementation, so they should not be defined by user programs. I can't quite remember whether leading _ is permitted in s …