Search Results

It's good that you've used strlen, but there's actually another standard function that could be useful here. Instead of your reverse loop, you can use strrchr to find a pointer to the last occurrence …

Since you're using cstdarg and va_list is a complete type, it should be std::va_list. va_start with a std::string is undefined behavior. This means that you actually cannot use std::string as your …

It's good that this is a reasonable runtime and reasonably efficient. I also like that you're not using using namespace std. There are, however, a few things I noticed that haven't already been addres …

Just a few things to add to john.k.doe's answer: cat's strlen calls The implementation of strlen is usually something vaguely like: size_t strlen(const char* str) { size_t len = 0; while (s …

This seems like a perfect opportunity to leverage the standard library. I would make a function to toggle a single character and then use std::transform on top of that. Not only is it more consise, it …

exactly match or if one of strings in its entirety is a prefix of the other. … (4) From (1), we can conclude that $ret1 will be 0 only if the strings exactly match or one of the strings is a prefix of the other. …

Pretty good overall, but a few things: Don't hard-code the 37. Instead, use the translation table's size. ll is a bad variable name. It's not descriptive at all, and it looks like 11. Your loop in l …

Over all, this is good, but there's unfortunately some very major performance problems, and I have a few minor design suggestions. A string can be reversed quite trivially in linear time. Your algo …

There's a host of better options: Return a vector of Strings instead of C-strings. Note: Can be done with no overhead with copy-on-write, but COW has it's own disadvantages. … C-strings are C-strings, and your String class is your String class. …

As Jamal implied, std::cin >> input will only extract one word. Since the prompt says words, I would assume this is wrong, and you should use std::getline like he suggested. set is vaguely named. W …

After years of criticizing others, I've finally found the time and worked up the courage to polish up one of my bits of code and solicit criticisms of my own. This is a simple dynamic-string library …

In other words, it would be more reusable if you had a function for reversing strings and then just output the reversed copy. … They convulute ownership semantics, introduce performance problems, and at the end of the day, a highly specialized smart pointer already exists for strings: std::string. …