Search Results

I agree with vvotan's points that this utility could be useful, not much but still. However, I'd go further with the implementation. This means it should be separated into two disposers: Managed & Unm …

Here're are my suggestions: Remove ConverterContract and ConverterActCompletion These two classes are unnecessary wrappers to hide the inner converter. You're saying that you're doing this to hide …

My observations... Leave generated classes alone You have modified Contracts by adding a custom constructor to it. You'll loose this changes when you regenerate the model. This class is partial not w …

Compiler error Unless you're using some experimental preview C# version, your code doesn't compile as this line: Value = singleValue ?? throw new ArgumentNullException(nameof(singleValue)); yield …

Use Dataflow You could use the ActionBlock from the System.Threading.Tasks.Dataflow package to let it handle the throttling of InitalizeSenderAsync method that you currently handle yourself: var wor …

Inheritance the point of inheritance and abstract base classes or interfaces is to have a common API that each type implements in its own way. Your inhertiance model doesn't do that. Classes that ar …

The code is not entirely wrong but it's not appealing either. Here are a couple of thoughts: In general I'd say this is ok and as far as WinForms are concerned not. Each of the abstract classes shou …

public interface IFaker<T> where T : class { Faker<T> GetFaker(); } I don't think you need this interface and the additional call to GetFaker. Instead you can derive your class from the Faker< …

throw new System.NullReferenceException("No CSV string has passed in the parameter"); You should not be throwing this excepiton in the BuildObject method (actually nowhere). It's not only that it …

@Adriano Repetti was faster with his list of issues ;-) so I'll just post an alternative soltuion where you can have everyting in only one linq query using the All extension. It will stop as soon as s …

Review IEquatable<T> protected bool Equals(Enumeration other) { return string.Equals(Name, other.Name) && Value == other.Value; } Two things about this method... If you implemented it, do …

Witout questioning your design here are a couple of improvements you can make. var obj = new T(); In your case creating this dummy and not actually used objects may hurt performance because you …

It's actually not uncommon that you have both the interface and a class that implements it the way you did it. In order to make the interface reusable for both case you need to make use of generics a …

I think in general your implementation is fine. You could however use the intefaces that are already provided by .NET: IObservable<T> Defines a provider for push-based notification. IObserver<T …

Is this the right way or is there an easier, smaller way to archive this? It depends on how you define the right way. Is your goal short and small code or is your goal testability and maintainabi …