Search Results

Rectangle as IEnumerable Is it a bad design for my rectangle to implement IEnumerable? Is it counter intuitive? I find a Rectangle implementing the IEnumerable interface is weird and counter intuiti …

DIP (Dependency Inversion Principle) The OnPremisesClient class violates the DIP (Dependency Inversion Principle) and the IoC (Inversion of Control) because it uses the Console internally directly. Y …

Here are few more things I'd like to add to the very good points mentioned by @Jk_xp. You use nested classes. This should be avoided because it makes finding and using class harder. For grouping you …

You might want to define the base type like this abstract class Primitive { public Primitive OpAccess(Primitive right) { switch (right) { case Number number: retur …

Without a deep understanding of the logic of this challenge here are some general ideas about the code. fields & properties class DelayItem { public object[] Data; public DelayTypes Type; …

You're crazy and the code is terrible :-P catch (FaultException<DefaultFaultContract> ex) { ((IClientChannel)client).Abort(); factory.Abort(); ExceptionHandlingHelper.HandleException(ex) …

In addition to @AdrianoRepetti's suggestions I find that the only public method you have there, the GetMailMessageInfos, does not require an instance. It could be just an extension for the MailItem[] …

Use Dataflow You could use the ActionBlock from the System.Threading.Tasks.Dataflow package to let it handle the throttling of InitalizeSenderAsync method that you currently handle yourself: var wor …

You make it more complicated then necessary. The duplication of all properties in the ItemBinder is a manintenace hell. I have this whole situation in two places in my program, and as it expands, …

throw new System.NullReferenceException("No CSV string has passed in the parameter"); You should not be throwing this excepiton in the BuildObject method (actually nowhere). It's not only that it …

You can shorten the first part to 3x this: var teamAverage1 = Players .Where(p => p.teamId == id && p.a == 'x') .Select(x => x.Average1) .ToList(); I don't like the p.a properties. They …

You can greatly simplify the code and remove a lot of repetitions if you move the nodes enumeration into a separate method: private IEnumerable<BinaryNode> Nodes() { var currentNode = root; v …

Current property You should never throw the Exception. There is almost always a more appropriate exception already available or you should create a new one. The name of the exception usually already …

My main question is to what extent should each class know about the other classes? At best nothing - they should know only about abstractions. (Further reading: The Dependency Inversion Principle …

I'd like to put in my two cents too. Storing types and creating names Your current code is based on strings e.g. you look for types by names that you both store in a dictionary and in the list. I fi …