Search Results

Summary Your resource management is broken. You have not implemented the rule of 3 or 5 and so you are going to leak and/or do double deletes. So let's concentrate on the Matrix part rather than resou …

Bad comments //validate bar code format bool validateBar(std::string) const; //convert integer zip code to string bar code std::string zipToBar(int) const; //convert string bar code to …

First the C++ code: class elevator{ liftbox box; class liftbox{ elevator ele; This is not going to work as you expect it. Each class contains an object of the other type means that both will …

Design Well your code seems to do a lot more than your initial design. So first of I would simplify all the code to do what the design is not do everything that you can imagine that the system needs t …

Your interface is BAD float Temperature::setFaren(){ float faren = newTemp+32; return faren; } float Temperature::setCels(){ float celsi = newTemp-32; return celsi; } So I can call t …

Personally I prefer objects that know how to read/write themselves from a stream. class Pod { public: Pod() // Should always have some form of constructor : angle …

Standard classes and derivation If a class does not have a virtual destructor it is not supposed to be derived from. Before we got the finally key word this was the indicator you were supposed to use …

This needs a lot of work to bring it up to current standard practices. Currently I would not consider this C++ code, but rather C code that happens to use some C++ features. All Upper Case Identifier …

Observation You can simplify this using arrays. You don't need two numbers for each type (max and current). Simply track the number of open spots (per type) and count down. if you are not using arrays …

Is casting a base class object to a derived class object given a type flag a good programming design? Usually no. It usually indicates a badly defined interface in your base class. A better way …

General Comments You don't do memory management correctly anywhere There is already heap functionality in the standard library. There is also a priority_queue that is based on this heap functionalit …

@Toby Speight describes how it should probably be done. But I want to describe what is happening in your case so that you understand the concept of copy construction and assignment. The problem is tha …

Design Review Ownership One of the advances of C++ over is C is ownership semantics. We understand who owns an object (and thus who is responsible for destroying the object). We do this by using a s …

Virtual Destructor If a class has virtual methods it should also have a virtual destructor. Now this is only important if you destroy a class from a pointer to the base class. Since your code leaks a …

This is all subjective: But I would prefer if the constructor set up the NeuralNet and was ready to go. Once the object there is no need to call extra functions like initializeLayers() or setHyperPar …