Search Results

One of the first things you should do if you have an arbitrary data set (as you do in your list of UserIds) would be to extract it out of the WHERE clause. Just make a @TempTable variable. If the data …

I have to compliment you on how well your query reads. Your aliases are short enough not to be a PITA to reference, yet descriptive enough to not have to scratch your head about what they mean. Your …

One by one, then: Is it good that I stored the posts in tables, or is it unnecessary? It is unnecessary, in this case. What your table variables are doing for you here really is simulating a sel …

A thing of beauty For such an odd/complicated logic, you certainly have made your code easy to follow along. Your comments are succinct and well used to label the CTEs. Your CTE names are perfect for …

There is not a whole lot to say, but I found a few small things that could be improved. Consistency DECLARE @username as NVarchar(60) = RTRIM(LTRIM(##DisplayName:string? ##)); DECLARE @userId as int …

A note on comments... Almost all of your comments already say what the function code says, since you are using clear naming. However, you have a behemoth function main() that is completely void of com …

Overall I think your query is pretty nicely written and returns useful information. Use some variables to refer to repeated values, for example, the GETDATE() reference could just be declared as a va …

Overall, very good I inspected your query closely and did not find anything standing out that could really be improved much. Here are some good points I found: Your formatting is consistent and the i …

Nothing bad to say, really! It's a pretty simple query so only so much can be said about it. Your keyword capitalization is consistent, your columns are well-referenced, overall nothing stands out. Th …

ORDER BY a.CreationDate DESC I think it would make more sense to sort by ASC so older Zombies show up first. I also think that SELECT TOP 100 is more an obstacle than a help. Since the data only refr …

I may be mistaken but I was under the impression that !=was not good SQL practice, rather <> is preferrable. e.g. WHERE Reputation <> 101 AND Reputation <> 1 --Exclude users without repchanges

Questions First to address some of your questions: Would this sql work with all relational DB's that accept SQL? No, it would not. In fact it's quite unrealistic (if not impossible) to write SQL q …

Comments Your comments are mostly clutter, and I mean that because your naming is good enough to where the comments are mostly irrelevant. Also, if you do need to make multi-line comment, you can use …

Good things You use good local variables, and you are consistent with your naming. The typical naming for T-SQL is using PascalCase, however there are no standards and snake_case or camelCase work jus …

Let's start with your input parameters, since that is SEDE-specific. Did you know you can add parameter hints to make the experience easier for users? See the SEDE Help Page. So we could do something …