Search Results

The first big issue that crosses my mind: Naming. In particular, commenting variables is always a sign that you did a poor job on giving them good names: int j = 0; // the trailing position of the sl …

Just a quick detail I haven't seen in the other answers: if (!isSaneArguments(a, b, c)) { throw new IllegalArgumentException("All sides of a Triangle must be > 0"); } First off, I don't really …

These are mostly going to be general comments. private Map<T, Node<T>> adjacencyList; This field can (and should) be made final. This applies to fields in your other classes as well. I also don' …

Something I like to do to counter this is using Optionals which before Java 8 would be using Google's Guava, but as of Java 8 it is a built-in functionality (though I still like Guava's implementation …

public interface Viewable<T extends Viewable<T, V>, V extends View<T>> { public void addViewCallback(final V view); public void removeViewCallback(final V view); } Drop the public keywords …

public void create_Created(){ This violates Java coding standards. In Java, the convention is camelCase, not snake_case. On top of that, the name create_Created is utterly meaningless. …

It is a Java standard to use camelCase, which means a method is named appendList, not AppendList. …

The common Java standard is camelCase, not snake_case. So variables should be named someVariable, not some_variable. Your method is (way, way) too long. …

I'd actually prefer a List (Java 8): public class ErrorInfo { private final List<String> messages = new ArrayList<>(); public ErrorInfo addMessage( String message ) { messages.add( message …

Something that I don't think has been mentioned: Don't return strings like that. The logic should be separate from the representation. So do something like public static enum PasswordValidationResul …

I know this is, for some reason, the preferred way to set braces in the Linux kernel code, but this is Java, not C. You are using hard-coded file paths. Absolute no-go. …

A few more things, next to the answer by 200_sucess: Your class maintains state and as such it should not be all static methods, but work with proper instances. However, you also use state in a rath …

Nothing android-specific, only regarding Java. Fetch_Details breaks Java conventions. Use camelCase! 14 fields in a class is too much and is just begging to be split into several classes. … If someone can't infer that from the code, they have never seen a line of Java in their life. …