Search Results

In Haskell, when you have a list, an index is not the idiomatic way to represent its items. What do you want with those indices? Agreed, your version is hard to read. …

Do the same with Operator and you've got: data BinTree op a = Leaf a | BinaryNode op (BinTree op a) (BinTree op a) Based on your haskell experience, you might want to write your Functor, Applicative, … Haskell philosophy Haskell is a functional language. While "functional" puts the emphasis on functions, it is actually data-centric. …

Please don't take any of this personal. -- all multiples of 3 less than 1000 multOfThree = [3*x | x <- [1..333] ] You need a comment for this, because the spec(fication) say 1000 and you use 333. W …

Generally in haskell it is recommended to either have only one data constructor with the same name as the type or different constructor names, e.g. data Tile = Closed Bool PlayerMarking | Opened Int In … is not regarded as idiomatic haskell, and here, you can do mostly without. (Mostly? It is inevitable for the player input.) …

Data representation My critique starts here: data Tree a = EmptyTree | Node a (Tree a) (Tree a) Why is a node forced to have 2 sub-trees? Given a graph like this: B1 - C1 | | A - B2 - …

The Answer based on mersenne primes is unbeatable in speed, but if you want to extend your code for abundant numbers sumDivisors n > n or deficient numbers ... < n, there are some options left. Low-L …

Naming, the first Normally haskell is written in camelCase, not under_scores. … i into a variable (or binding, as haskell programmer might prefer) named state. This is a list (of lists). …

There is some asymmetry in your code: addPairPreservingGraphTransitivity gr c@(a,b) | F.any ((== b) . fst) gr = S.insert c . S.union gr . S.map (\x -> (a,x)) . S.map snd . S.filter ((== b) . fst) $ …

A haskell beginner using Control.Lens... Certainly better than my first program which happened to a tic tac toe solver, so I can compare. We all know Why functional programming matters, don't we? …

I am building on bisserlis' answer here. interpret uses a lot of repetition that can be reduced with case..of. That allows a where clause which factors out common code that modifies memory and simply …

Specify imports Do you know the names of all functions in Data.List? Me neither. Specify what you import like import Data.List (delete) In my final version, this becomes import Data.List (minimum …

The google results for haskell levenshtein Array are only marginally better than your Vector approach. …

I concentrate on Are there segments that could be more idiomatically written? and probably overdo it. fst $ runState can be written as evalState. Look at this: vl <- validateSequence (r …

At some point in you haskell journey, you will do that. When you grow wiser, you will value readability over succinctness. Long story short: This part is OK. …

Of course the haskell way of writing it is f x | x > 1 = "bar" | otherwise = "foo" but I like my code to closely mirror the problem statement, see next section. …