Search Results

Here are some things that may help you improve your program. Use the required #includes The code uses std::find_if which means that it should #include <algorithm>. It was not difficult to infer, but …

No problem with that at all, since it's not the copy which is doing the conversion (which would be strange) but the constructor. Since the vector templates you've mentioned are clearly of different t …

It seems a bit of a bother to approach it as a function template when it seems to me that it's more like an object. For that reason, here's an alternative that might be a little more natural to use: …

In all, there's not much to complain about, but I did find a few things that might be improved. All of my comments and testing are about C++11 mode, since that's what I have conveniently available. U …

I see a number of things that may help you improve your code. Improve naming The names Row and m_table are good because they are descriptive, but num_float and num_int are not very good. It would b …

I see a number of improvements you could make to your code. Rethink your classes There are a number of parallel vectors that each hold one element of a task. I'd highly recommend instead creating a …

Here are a number of things that may help you improve your code. Don't abuse using namespace std Putting using namespace std at the top of every program is a bad habit that you'd do well to avoid. …

Here are some things that may help you improve your program. Fix the bug There is a problem with updateListExe that occurs in the test program after removing one element from the list. It accesses fr …

I see a number of things that could help you improve your code. Don't abuse using namespace std Putting using namespace std within your program is generally a bad habit that you'd do well to avoid. …

Here are some observations that may help you improve your code. Don't abuse using namespace std Putting using namespace std at the top of every program is a bad habit that you'd do well to avoid. …

It's a short bit of code, but enough to work with, I think. Here are some suggestions to help you improve your code. Minimize the number of comparisons There is not really a need to check both uppe …

Here are some things to help you improve your program. Don't mix I/O with data operations Generally speaking having a std::getline and std::cout within a data class such as Class is not a good idea. …

Here are some things I saw and some suggestions for how you might improve your code. Try not to repeat information I don't much care for the two parallel maps because they have the same information …

Here are some things that may help you improve your program. Separate interface from implementation The interface goes into a header file and the implementation (that is, everything that actually emit …

I see some things that may help you improve your program. Don't abuse using namespace std Putting using namespace std at the top of every program is a bad habit that you'd do well to avoid. Elimi …