Skip to main content
Search type Search syntax
Tags [tag]
Exact "words here"
Author user:1234
user:me (yours)
Score score:3 (3+)
score:0 (none)
Answers answers:3 (3+)
answers:0 (none)
isaccepted:yes
hasaccepted:no
inquestion:1234
Views views:250
Code code:"if (foo != bar)"
Sections title:apples
body:"apples oranges"
URL url:"*.example.com"
Saves in:saves
Status closed:yes
duplicate:no
migrated:no
wiki:no
Types is:question
is:answer
Exclude -[tag]
-apples
For more details on advanced search visit our help page
Results tagged with
Search options not deleted user 37788

Add this tag to your question to indicate that you are new to the language of your code. This will often be taken into consideration by reviewers when assessing your code.

20 votes
Accepted

Modelling a Call Center

Firstly, I'm not sure you're actually implementing the requirement as it's written. The description says: An incoming call must be allocated to a fresher who is free. If a fresher can't handle the ca …
Ben Aaronson's user avatar
  • 5,734
10 votes

Menu to save and load football team information

DRY Let's start with your methods arsenal(), astonVilla() and so on. From the title of the question, I think you're already aware these are problematic. Remember that while at its core your program is …
Ben Aaronson's user avatar
  • 5,734
7 votes
Accepted

Counting occurrences of different categories of characters

The good: Good naming, both in following conventions and in picking expressive names Your approach is good procedurally- e.g. good use of the dictionary and in-build char methods. Putting the result …
Ben Aaronson's user avatar
  • 5,734
5 votes

Checking if a string contains vowels

As a general note, I'd say that code like this is great for learning and getting comfortable with a language, IDE, etc. But it's unlikely to get reviews which are very helpful. If you want to write …
Ben Aaronson's user avatar
  • 5,734
5 votes
Accepted

Unit testing a CharGrid

C# conventions The assignment you posted from is written for Java. While the syntax is similar, C# has some slightly different conventions with naming and formatting. In particular, in C# it's normal …
Ben Aaronson's user avatar
  • 5,734
4 votes
Accepted

BMI calculator/assessor

Because this is such a simple program, there are really only a few basic things that can make it good or bad (beyond the fact that it actually works). The good: Formatting - this is all consistent …
Ben Aaronson's user avatar
  • 5,734
4 votes
Accepted

Rounding and formatting hours, minutes, seconds as HH:MM AM/PM

DateTime handling It's possible that you're prohibited from using the DateTime struct in this method since this is apparently homework. But, in case you're not aware, problems which are as common as p …
Ben Aaronson's user avatar
  • 5,734
3 votes
Accepted

Solution to Project Euler problem 5 (LCM of 1 to 20)

Let's start with the loop inside findPrimeFactors. You have the right idea, but it's complicated because you're flattening two loops into one: looping over the primes, and looping over the factors for …
Ben Aaronson's user avatar
  • 5,734
3 votes

Return true if the elements of an array do not contain one or the other

Generally, your naming is good. I never like nums as a name, but sometimes, like in this case, it's hard to see anything more descriptive. Perhaps just numbers. no14 is also not a great name, though s …
Ben Aaronson's user avatar
  • 5,734
2 votes

Using recursion to count substrings (with exceptions to the rule) in Java

I don't have much negative to say about this- the algorithm seems good, and it's expressed in a way that's clear and easy to understand. The only points I might pick up on: Naming/style str isn't a …
Ben Aaronson's user avatar
  • 5,734
2 votes

Finding the relationship between two values

Generally, this looks pretty good. There are a few points to make, but it's worth first saying that because this is such a simple problem and solution, some of these may seem a little pointless. I'll …
Ben Aaronson's user avatar
  • 5,734