Search Results

I have taken a while to answer this question (I started, then work got in the way...). Now that I am back to it, I see that Simon has posted a good review... So, part 1, a review (and then later, a s …

Unfortunately your code has a bug. If there is a mis-match on the end-string, you roll-back the pointer for the end-string to the init value. You should also roll-back the pointer in the s string so t …

This is a nice short piece of code, though it has a number of 'features' which can be improved. Code Style Java code style recommends a lower-case letter to start method names.... Puzzle should be p …

Style Java Code-style conventions put: the { brace at the end of the line that introduces the compound statement block, not on the next line. spaces between variables and operators: for (int i=0;i<le …

replaceHelperAlt(chars, i + 1, result); } } } The above solution has the benefits of: no unnecessary List instances and String instances are created (the only strings created are actual …

This has presented an interesting problem. Your solution concerns me, because it does not solve things the way I would. This, in itself, is not a problem, but I had to look through your code, and figu …

The net result is that you have a performance of \$O(nm)\$ or \$O(n^2)\$ depending on whether there are more characters in the searchIn or searchFor strings. …

Style if (s.length() > TARGET_LENGTH) { if (s.contains(SEPARATOR)) { if (s.substring(0, TARGET_LENGTH + 1).contains(SEPARATOR)) { return s.substring(0, s.substring(0, TARGET_ …

I am a fan of using primitives. In this case, the performance benefit would be minimal, but the number of copies would actually be less..... In reality, I would probably use the StringBuilder approac …

String.split is a special case of using regular expressions. Just because it does not return the position of the words, does not mean that regular expressions themselves are not the right solution. C …

It is things like this which drive me nuts, and I agree with you, your solution is good, but ugly. Your solution is also probably close to being as efficient as possible in Java, using the StringBuild …

Regular expressions are another option: $name = "Tom Smith" $short = $name -replace "(?<=^.).*\s", "" $short The above code replaces the second character, through to the last space, and replaces th …

Text manipulation like that is always a pain. I like to extract functions for things like this, though. private static final String simplePlural (int count, String noun) { if (count == 1) { …

In Java, and in Code Review, the preference is for creating both highly readable, and highly efficient code. It is an almost bizarre fact, that one leads to the other. your code has one efficiency, …

(never mind, no two strings will have the same length). Instead of if (a.length() > b.length()) ... and if (b.length() > a.length()) you should simply use an if (....) {....} else {....} …