Search Results

Use modern C gets() has been dropped from the C standard library since C11 (12 years) and was even then considered poor practice. Consider alternatives like using fgets() for all user input. Test not …

I am looking for is comments on whether my use of the context struct makes sense in the way it is handled, whether there may be some way around having to dynamically allocate the context behind the …

Good formatting and layout. Aside from bug, good code. Bug? I'd expect v[1] + delta, v[0] + delta per Tiny Encryption Algorithm. // Reference code // for (i=0; i < 32; i++) { …

Arrays are best indexed with type size_t rather than unsigned. Notice unnecessary mixed int/unsigned types in i<=n. Both should be size_t. Avoid naked magic numbers. Why 16 in unsigned char B[16]? …

Invalid code In while ((x = getc(file)) != EOF), where is x defined? 1 error: 'x' undeclared (first use in this function) Use of uninitialized object The pointer mes is passed to mpz_export() without …

Fatal: Insufficient memory allocation. Buffer is too small by 2 for s[length+1]. char *s = malloc(length); ... s[length+1] = '\0'; Minor: long will not necessarily will fit in size_t. long fs …

. // short result = 1; int result = 1; ... return result; Cryptography begs for unsigned types Instead of long, consider the widest unsigned type of uintmax_t or the widest fixed size type: uint64_ …

Nice implementation. Good attention to shift types. Use bool. Various members, functions are used only in a boolean fashion. Use bool to add clarity to that use. Yet I suppose this goes agains …

Avoid unsigned math mistakes My code works well if I provide a good key, but if the key is bad (plain[i] ± hash < 0) plain[i] ± hash < 0 is never true. This is an unsigned compare. An unsigned sum …

So I am wondering if there is a proper more correct way to do it. binary data An encryption of a file should not assume it is text lacking a '\0'. As a binary file, data may include null charac …