Search Results

Sorry, I know this is stale. First things first, from a code quality perspective, it's usually not good to have redundant cases. e.g. [x, y] and x:y:xs will both match 1:2:[], and you'll get the behav …

There's no particular reason to want to not have a solve', except maybe that it's hard to give it a good name. If you're worried about clutter; putting it in a where clause is fine. solve already has …

Sometimes that's not enough, and it doesn't work for arguments you're not binding, so deffer to a more formal style of comments, which in Haskell means Haddock. … That's certainly idiomatic Haskell! but it usually isn't one's first strategy. …

Some Haskell-specific code-smell stuff also applies: Visited is used like a Bool, so let it be a Bool. (You can wrap it up various different ways for clarity though!) …

I'm a little out of practice with haskell, but I'm quite fond of it. I want to address your "extra" question first. wich one of the 2 version is more readable for an haskell programmer, and why ? … [sic] Haskell programmers aren't a special magic kind of people. …

For a complete executable that actually does anything, this is fine and to-the-point. Trying to reduce boiler-plate would just be golfing. cart2pol is great. If this is part of a larger code-base, the …

Since you're using Haskell, I'm guessing you want the compiler to be picky with you. using the -Wall flag is a good idea; there's some discussion about how to take this even farther here. …

Finding pleasant ways to talk about things like failure is its own learning-curve in Haskell. While not technically wrong, it's kinda sketchy the way you're checking the number of guesses twice. …

help you debug it, that's fine.) you can often avoid using lift so much by leveraging the MonadIO class. single-character variable names are ok when they are in some sense "fully general", it's kinda a haskell …

The amount of repeated code isn't large, I don't think that's worth worrying about. It does seem like you've got a lot of buried cases making your nice do block hard to read. I don't think you can use …

I'm not about to set up benchmarking to measure the performance, and the code is fine idiomatic haskell. …

Are there any subtle Haskell-isms that I have that could easily be removed to make the more approachable to a general audience? … That's hard to say; I'm probably too familiar with Haskell to count as a general audience. Add a few comments. Maybe get rid of instance Alternative Parser. …

I'm new to Haddock and couldn't figure out how to comment the whole module. I think the problem is that the module description needs to have some internal structure. See here I'd like to know how c …

Our first question should be "why is it O(N^2)?" The sort seems to be a merge-sort; I trust that it's O(n log(n)). But insert is noted as O(N), and you're calling it O(N) times, so it's a good bet tha …

This is quite decent! Things I would want to change: The way you're representing Libraries is odd, smelly, and generally frowned upon. If you were going to have an enum data Library = Accursio | A... …