Search Results

Docstrings You should include a docstring at the beginning of every method, class, and module you write. It allows anyone to view how to use and implement your method, using your_function_name.__doc_ …

Indentation You should indent 4 spaces. Here's the PEP 8 guidelines on this. Equality Instead of while (sum(player) <= 21 and stay == False and play_again == True): do this while(sum(player) …

Have a look: name=input("Name: ") # WRONG name = input("Name: ") # CORRECT This is a convention outlined in PEP 8, the python convention guide. …

Your getRank function could use a little flexibility. If the user inputs low, their input is rejected as incorrect. To solve this you can take the first character of the string passed. Since you index …

Unnecessary parentheses Switch the following: return(...) -> return ... if(...) -> if ... You switch between the two, probably due to coming from another language. Just try to be consistent and don't …

You can accomplish this with itertools.combinations. A lot of the pythonic code you will see is just clever use of built-in functions and libraries. Getting familiar with these will greatly speed up y …

I've written classes Store, Cart, User that manages methods that allow the user to add/remove products from a shopping cart, as well as being able to query different descriptions about the item (id, p …

Use of global: It's not recommended to use global variables in python, or any language. This StackOverflow answer provides more insight. …

You've essentially built a glorified Caesar Cipher. Not all of the changes I suggest below are included in the final version of the reviewed code, but they should be considered. Here they are: Comme …

General Changes Move any input code to the bottom of the file, inside a main guard. Avoid using global variables, instead pass them as parameters. Variable names should be in lowercase or snake_case. …

Naming: Python variables and parameters should be in snake_case, not camelCase. len as condition: You shouldn't use if len(self.title):, instead you should check if it doesn't exist, if not self.title, …

Reserved Names type is a reserved name (function) in python, so you should rename it to something like file_type, or along those lines. While we're talking about variables names, what are these? …

Disclaimer: These type hits are written using Python 3.11, so you might need to update your python to run with type hints. If that's not possible, simply remove them. … Reading lines from files Instead of checking yourself if you've reached the end of the file, let python do it for you def read_inputs_from_file(filepath: str) -> list[str]: with open(filepath, 'r') …

Disclaimer: I have never worked with multiprocessing, so I can't comment on that implementation. Handling Files I noticed at the top of the file you open a file, but never close it. (For the argum …

A simple and pythonic way to accomplish this is using collections.Counter. It's an easy way to count elements in an iterable. Have a look: from collections import Counter def unique_letters(string: …