Skip to main content
Search type Search syntax
Tags [tag]
Exact "words here"
Author user:1234
user:me (yours)
Score score:3 (3+)
score:0 (none)
Answers answers:3 (3+)
answers:0 (none)
isaccepted:yes
hasaccepted:no
inquestion:1234
Views views:250
Code code:"if (foo != bar)"
Sections title:apples
body:"apples oranges"
URL url:"*.example.com"
Saves in:saves
Status closed:yes
duplicate:no
migrated:no
wiki:no
Types is:question
is:answer
Exclude -[tag]
-apples
For more details on advanced search visit our help page
Results tagged with
Search options not deleted user 151754

For when you know you are reinventing the wheel, but are doing it anyways. Questions with this tag involve code that is already fully implemented (such as from a library).

5 votes
Accepted

Moving objects on a grid in C++

The first thing to do to clean up the code would be to make a struct pos { int x; int y; }; This will simplify the remaining of the code, making it easier to reason about the logic. For exam …
Cris Luengo's user avatar
  • 6,237
3 votes

My iterative FFT is slower than my recursive FFT

It is hard to compare implementations seeing only one. It is possible that you can write the algorithm in a different way that makes it more efficient. Seeing only one specific implementation, all we …
Cris Luengo's user avatar
  • 6,237
3 votes

Unit testing a Linked List implementation in C++

This is going to be a superficial review, I hope someone else will go into details on the C++ code. I don’t see any issues with your makefile, and don’t understand why you would need to include single …
Cris Luengo's user avatar
  • 6,237
5 votes

Image Processing Median Filter in C

You’ve got some excellent answers commenting on the code itself. I am here to comment on the algorithm. It is really hard to implement a color median filter. The median is defined for a set of scalar …
Cris Luengo's user avatar
  • 6,237
1 vote

Image Processing Sobel Edge Detection in C

There is one thing I thought of when reading your code that hasn’t yet been mentioned in the other two reviews: for(long long int i = 0; i < (xsize * ysize); i++) { if( (i < xsize) || ( (i …
Cris Luengo's user avatar
  • 6,237
8 votes

Implementation of Linux cp in modern C++

I am going to focus on these two lines of code: int infd = open(input.c_str(),O_RDONLY); int outfd = open(output.c_str(),O_WRONLY|O_CREAT|O_EXCL,0664); Since you are making a point of using modern …
Cris Luengo's user avatar
  • 6,237
8 votes
Accepted

Two dimensional gaussian image generator in C++

You are obviously on a fantastic quest to understand how to implement image processing operations in all sorts of languages. The tag reinventing-the-wheel tells me that you know that you should use an …
Cris Luengo's user avatar
  • 6,237
7 votes
Accepted

conv2 Template Function Implementation for Image in C++

Algorithm I like the algorithm you use. Usually people will implement convolution by doing all computations for one output pixel in the inner two loops. I honestly don't know which is more efficient, …
Cris Luengo's user avatar
  • 6,237
2 votes

im2double and im2uint8 Functions Implementation for Image in C++

When you create an empty vector, and repeatedly emplace_back() pixels, you do a lot of reallocations that you can avoid by reserve()ing the right number of pixels before the loop. Next, you put this v …
Cris Luengo's user avatar
  • 6,237
4 votes
Accepted

imgaussfilt Template Function Implementation for Image in C++

I have strong opinions about the Gaussian filter, don't take this personally. :) First of all, you should know that the Gaussian filter is separable. That is, you can apply a 1D Gaussian filter to the …
Cris Luengo's user avatar
  • 6,237
3 votes

convn Template Function Implementation for Image in C++

Continuing G. Sliepen’s answer: Another strange name is level, it indicates which image dimension the loop works over. It has nothing to do with levels. dimension would be more appropriate, and would …
Cris Luengo's user avatar
  • 6,237