Search Results

You can use braces to return from your functions. That way, you won't have to repeat long and cumbersome types (DRY, as much as possible). For example, ConditionalRange::end: iterator_type end() cons …

I still have trouble understanding how the whole works, but there are still some small things that could be improved: In your comments, you say that A is an integer type used as a bitmask. The safes …

Some things you can improve: The initialization of reserved_words is far too complex. You can use an initializer it to simplify it: static const std::unordered_map<std::wstring, LexedFile::Token> r …

I don't see any real problem, only tidbits and things that could potentially be done differently: Your header guard name is actually reserved to the implementation since it uses a double underscore. …

You can make the class template with trivial changes (add template<typename T> and change int by T in your classes), then make a construction function that deduces integer types: template<typename T> …

You can get rid of the <type_traits> header by replacing your std::enable_if by a bool template specialization: template <::std::size_t, ::std::size_t, bool> struct expand_indices_impl; template <:: …

There are way too many const in your code. const-correctness is great, but you are overdoing it. A few tips to improve your code: When I run g++ with the option -Wextra, I get a warning with this pi …

A few notes to complete what @vnp already said: When you open several namespaces at once and close them at once, you better indent only once since the double indentation won't add to clarity but wil …

std::call_once is an interesting tool, but there are alternatives built into the language: namely, you can use the Immediately-Invoked Function Expression (IIFE) borrowed straight from JavaScript and …

First of all, you should pass the std::string by const reference and not by value, therefore, replace std::string s by const std::string& s, otherwise you will make a whole copy of the string everytim …

Here are some small things you could di in order to improve your design: First of all, you have a typo: you wrote Map::Iiterator begin(); instead of Map::Iterator begin();. You use KeyType and DataT …

There is not much to be said actually, the concept-based polymorphism seems to be well implemented. You can slightly improve your push_back method by having it emplace_back the std::unique_ptr. It wil …

I can't answer all your questions, but here are some things you can improve or some guidelines you can follow: Always pass std::shared_ptr by const reference. There are several reasons for this, som …

I can't say for sure about the internal logic but I can point some problems or things that could be improved in your piece of code: First of all, typename is missing before the names, making your co …

Here are some small things you can improve: constexpr inline isn't necessary: constexpr already implies inline. In the following function: constexpr friend inline Arithmetic operator+(Arithmetic a, …