Search Results

Naming conventions aside (short names in camelCase are typically used in Go), this is the right way of doing what you want. … The authors of Go have a different view of what is more readable & maintainable than the authors of Python :-) …

Your code is pretty idiomatic. The only obvious style thing I'd change is the end of the evaluateIndex function: if strings.HasPrefix(hash, "00000") { return []rune(hash)[5] } return 0 you …

In Go, foo, _ := something() is a big code smell. Iterating on a string gives you a rune; don't convert it to a one-char string just to compare it to another one-char string. …

Your naming conventions aren't very Go-like. … stringArray is very wrong: this variable is a byte slice, plus, it doesn't give you extra information from its type TestBinryGap should probably be TestBinaryGap testObjects is weird and slightly misleading; Go …

In Go, you would use i instead of rowIndex, floatArray instead of make2dFloatArray, ConvertCSV instead of ReadFromCSV, etc. … See this for a detailed discussion on why Go doesn't have generics for now. …

services the call to strings.TrimSuffix can be avoided using a simple condition in your template you can replace (select company.id from company) directly by its value, that you previously computed in your Go … code and you can get rid of the []interface{} variable that you pass to Prepare & Exec, just do all the substitution logic in the go code. …

You client code is incompatible with the argument type of valueInterval (I guess you meant to write valueInterval{0, 100} instead of 100?). But this is strange to have min for an expiration time, most …

If some of your init values (prefix, filePath, fileName) are empty, you should fail on init, not once you try to log something. Returning errors as soon as possible is a good practice and makes debug …

So you can initialize directly with the correct allocated capacity: line := make([]byte, 0, len(bytes)) okay, now let's go even further: calling append at each iteration means that under the hood … b <= 'Z' { b = ((b-'A')+shiftB)%26 + 'A' } else if b >= 'a' && b <= 'z' { b = ((b-'a')+shiftB)%26 + 'a' } line[i] = b } return line } We can go …

Your Add function go away, but fyi: you are making it return a bool and never using it. Your pop function could be simplified and inlined. Just use ip, parts = parts[0], parts[1:]. …

Consider using the html Go library instead. …

Your code is mostly fine. The following comments are nitpicking. I agree with Elias, your default implementation should be thread-safe. Instead of returning nil, I would suggest your Pop function ret …

The call to regexp.MatchString is the only really expensive part of your code. Do you need full regexp support? If you just want to find substrings, you should use strings.Contains instead of the rege …

Some high-level comments after one pass on your code: Don't panic. Handle errors instead; and use log.Fatalf at the highest level. Don't use underscores in variable names. Your variable names are al …

Style comments Don't panic. Return the incorrect value of n in your error using fmt.Errorf. Use gofmt on your code. (Have your favorite editor call it on-save.) There is no better way to convert a b …