Search Results

Update @steenslag points out the minmax builtin. No monkey patching necessary. template_min_datestamp, template_max_datestamp = Template.range(:created_at).minmax

hsh = {} preferences.each do #something that updates hsh end A more idiomatic Ruby way to do this is with a map, as the answers show. This will in general result in more concise, expressive code. …

Code review-wise, I'd avoid long if-elsif chains and see about converting them to a case. Also, I'd move the final formatting to the end. Otherwise, not too bad except for the fact that there are much …

I would be more formulaic regarding the century calculation: century = (year - 1) / 100 + 1 Also, consider using .ordinalize from ActiveSupport (via require 'active_support/core_ext/integer' - you …

You may want to look into JSONPath, which gives you XPath-like querying of JSON objects. Note that the leading zero in your sample JSON makes it invalid.

A very clean approach is to use the xml-simple gem. Simply use xml_out with two options: RootName to specify the XML root element AnonymousTag to provide a tag name for your top-level hash Other o …

The reason why it doesn't look clean is because the underlying models are inconsistent. In one, you return a boolean true/false for age_eligible? and in another, you call it age_eligible_code and sto …

I would model the domain with objects. A good set of classes would be Deck, Player, and Card. This will hide away implementation details and keep things easy to read. It also helps with naming, e.g. a …

One-to-one substitution is precisely what tr is for. def norwegian_upcase(string) string.upcase.tr('æ-ý','Æ-Ý') end That being said, the unicode_utils gem provides a method for this: def norwegi …

It's a good idea to become familiar with all the methods on Array and Enumerable. It just so happens that Enumerable has a method called partition that has a purpose of dividing an array into .two par …

Review Overall, I don't see anything wrong stylistically. I wouldn't be too concerned about performance unless you have extremely large arrays -- do you expect either the values "buckets" or the inpu …

One of the ways to structure your objects is to describe your problem in a sentence or two, then turn the nouns into classes, and the verb phrases into methods. In this case, you may end up with Hang …

I won't talk about style, because @tokland's comments are spot-on. However, some quick notes about efficiency. For large board sizes, this implementation is inefficient. For example, neighbors_to sc …

Overall, it's reasonably tight code. You've taken steps to reduce method size, which is good. To answer your questions specifically: I think an instance variable would be better, because then you c …

puts (1..20).reduce{|m,n| m.lcm(n)} or even shorter: puts (1..20).reduce(:lcm) Because most of the calculations are done in the ruby implementation (e.g. C for MRI), this will be fast. …