Skip to main content
2 of 5
deleted 1 character in body
Phrancis
  • 20.4k
  • 6
  • 68
  • 154

I see some of the same problems as in your last query

Do not use single-letter aliases

a, m1, c1... How about an alias that helps you write the query, instead of one that saves a few characters? That's what they are for, after all.

Old style JOIN

I think you would benefit from reading about explicit JOIN syntax instead of using the pre-ANSI-92 syntax.

Vertical white space

I personally find queries much easier to read if you use line breaks between lists of columns/values/conditions, instead of writing them inline.

Column aliases

It's good practice to rename short/ambiguous/ugly column names to something more human-friendly while presenting the result set. To you it may not matter much, but if you were presenting this report to your boss, they may scratch their head at fname and lname. The syntax for column aliases is the same as table aliases.

That Devil BETWEEN

BETWEEN is ambiguous. You should instead use logical operators.

#The reviewed script#

SELECT DISTINCT 
    Actor.fname AS ActorFirstName, 
    Actor.lname AS ActorLastName,
FROM 
    Actor -- look no alias needed
    INNER JOIN Cast AS OlderCast ON OlderCast.pid = Actor.id
    INNER JOIN Movie AS OlderMovie ON OlderCast.mid = OlderMovie.id
    INNER JOIN Cast AS NewerCast ON NewerCast.pid = Actor.id
    INNER JOIN Movie AS NewerMovie ON NewerCast.mid = NewerMovie.id
WHERE
    AND OlderMovie.year >= 1850 
    AND OlderMovie.year <= 1900
    AND NewerMovie.year >= 1901
    AND NewerMovie.year <= 1950;
Phrancis
  • 20.4k
  • 6
  • 68
  • 154