Questions tagged [comparative-review]
This tag is used for questions which present a problem and multiple solutions, where the asker wishes to know which solution is best (and why).
930
questions
4
votes
2
answers
601
views
Displaying IP addresses in Go using Stringer interface
I am trying out some Go code examples (while coding a private project) to get more "in-depth" knowledge about the language.
I have come across an exercise from the Go Tour website about displaying ...
0
votes
1
answer
188
views
Adding a Node to the Linked List is taking a longer Time when using a reference to the Tail Node
I am trying to add two numbers in the form of linked List and return their result in a Linked List as given in https://leetcode.com/problems/add-two-numbers/
Question:
You are given two non-empty ...
- 109
2
votes
3
answers
156
views
Finding the next available filename [closed]
We're having a small debate in work about the following piece of code:
...
- 273
7
votes
1
answer
359
views
Function to send email, refactored based on SOLID principles
I have the below method that is responsible for generating and sending a MailMessage using a SmtpClient object:
...
- 509
4
votes
1
answer
389
views
Evaluating π using Monte Carlo methods - Serial vs OMP
I wrote this simple code for evaluating the π using Monte Carlo method. This is the serial version:
...
- 227
5
votes
1
answer
132
views
Detecting the presence of multiple URL segments
I have two versions of a function that performs the same task, however I'm not sure which one to use. Speed is something to take into consideration, but I also want to know what the best practice is. ...
- 185
0
votes
1
answer
96
views
One try with multiple catch blocks vs nested try
I am creating program which will parse .csv file and I am using FileReader and Scanner classes from java API.
...
- 103
3
votes
3
answers
97
views
Find minimum value in a BST: using boolean operators, and using conditionals
I've been studying the BST code in Paul Graham's ANSI Common Lisp.
He provides (my comments):
...
- 493
1
vote
1
answer
318
views
Two solutions to 2-sum
I have written a solution for two sum problem in variation. first is simple with two loops and another one is one loop and hash map.
But I wonder why the simple solution is faster than the efficent ...
- 197
2
votes
1
answer
341
views
Nodejs functions to load and save RSA keys
I'm creating my first real life Nodejs project. I've created some files and all work, but I'm not satisfied about what my files look likes. It's unreadeble.
For example, I work of a file to manage ...
- 23
5
votes
3
answers
852
views
SkipLast of an IEnumerable<T> - Linq Extension
As my answer to this question, I came up with this solution:
...
user73941
3
votes
1
answer
151
views
Pre-calculate the winning combinations for an n-sized tic tac toe board using C++ functional programming
This code pre-calculates the winning combinations for an n-sized tic tac toe board.
I first created my function using an imperative approach. This is just how I naturally write code most of the time....
- 141
1
vote
1
answer
41
views
Aspect-oriented vs explicit style in Python [closed]
Readability counts, but is very subjective. The following snippets are equivalent in functionality and turn a generator iterator into a chunked HTTP response in Flask. Which of those two patterns is ...
6
votes
1
answer
1k
views
Avoid using C Strings on C++ code to trim leading whitespace
I'm learning C++ and wrote a function to remove all the spaces and tabs at the beginning of the input string. It removes them until it find a character different of space and tabs.
In the first ...
- 253
2
votes
1
answer
64
views
Two ways to implement DND type abilities
I am creating a game in Java that uses the DND model for a lot of its components. I've hit a roadblock when it comes to creating and implementing abilities. I have ...
- 9,719
6
votes
1
answer
217
views
EEPROM-based filesystem, aiming for Misra C++ 2008 compliance
I'm writing code for embedded systems (IAR compiler) and it should adhere to Misra C++ 2008. This limits the available features of the language quite a bit:
no C++1x features
use of the standard ...
- 169
2
votes
1
answer
79
views
Fetching configuration or default value
I have two code snippets, doing exactly the same thing and both get the job done:
use defaults
use from config
Which is cleaner to use in golang and why?
first option:
...
- 141
4
votes
1
answer
69
views
Showing a "back-to-top"-button after scrolling a certain amount
I have a "back to top"-button on the page, It should be visible after the user has scrolled a certain amount*.
This means I have to add or remove a class active ...
- 245
3
votes
1
answer
92
views
Most efficient way to check if user is allowed to update an object
So I have an user which can create his own Locations.
I implemented a webservice in order to add and update locations. If the user is not the owner of the location i want to throw an appropriate ...
- 141
5
votes
1
answer
414
views
Two ways of implementing a combat system
Below is a segment of a game I am writing to stay in practice with my Java.
EDIT The class this method is in is the Encounter class. This class just manages the encounter between the player and an ...
- 9,719
5
votes
2
answers
421
views
Optimizing Luhn check digit algorithm
The internet as a whole and Code Review in special already provide a decent amount of implementations of the Luhn check digit algorithm. They often follow a relatively "naive" strategy, in that they ...
- 7,244
5
votes
1
answer
7k
views
Merge Two Sorted Lists in JavaScript
The task is taken from LeetCode
Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two
lists.
Example 1:
...
- 3,973
2
votes
1
answer
77
views
Populating dropdown lists, using SQL vs. using expression trees and reflection
I'm working with a large enterprise SQL Server database with dozens of tables that are used mainly as lookups to populate dropdown lists, etc. These tables all follow the convention of having (table)...
- 189
4
votes
0
answers
198
views
Java multithreading many readers one writer implementations
I have a shared data object with writer threads and reader threads. Number of threads can read from the shared data at the same time (in the code getmethod), and ...
user97059
2
votes
1
answer
461
views
Length of the longest consecutive run of 1s in its binary representation
The task
Given an integer n, return the length of the longest consecutive run
of 1s in its binary representation.
For example, given 156, you should return 3
My function solution 1
Style 1
...
- 3,973
0
votes
1
answer
40
views
Filling in the card expiry date from transaction data
I'm integrating my app with a payment gateway, and have the following code which returns an array to populate the transaction info:
...
- 146
2
votes
2
answers
512
views
Python program for Jump game II
This is a Leetcode problem:
Given an array of non-negative integers, you are initially positioned at the first index of the array.
Each element in the array represents your maximum jump length ...
- 2,458
-3
votes
3
answers
1k
views
Python program to find the first missing positive integer in a list
This is a Leetcode problem:
Given an unsorted integer array, find the smallest missing positive
integer.
Note:
Your algorithm should run in O(n) time and uses constant extra space.
...
- 2,458
7
votes
1
answer
1k
views
Usage of TPL vs Parallel.ForEach() on file processing
i've been working on an implementation of a my own from scratch set of library Astron and I wanted to get my TPL usage reviewed because i'm not confident with this technology :/
My app is currently ...
- 153
3
votes
1
answer
80
views
API for multiple printer attributes [closed]
I have network printers which have different attributes (e.g. supported network protocols, languages, status, print modes).
...
- 173
5
votes
2
answers
867
views
Create a min stack
The task
is taken from leetcode
Design a stack that supports push, pop, top, and retrieving the
minimum element in constant time.
push(x) -- Push element x onto stack.
pop() -- Removes ...
- 3,973
3
votes
3
answers
51
views
Counting duration values
I have a durations as such:
[{'duration': 3600}, {'duration': 3600}]
And I want the output to be ...
- 185
5
votes
1
answer
274
views
Container with most water
The task
is taken from leetcode
Given n non-negative integers a1, a2, ..., an , where each represents
a point at coordinate (i, ai). n vertical lines are drawn such that
the two endpoints of ...
- 3,973
4
votes
1
answer
171
views
Return all valid paren strings with a given length
The problem is
Given a non-negative integer n, return all valid parentheses strings
with n open parens and ...
- 175
8
votes
5
answers
616
views
Checks user level and limit the data before saving it to mongoDB
I have a function that checks user level and limits the data before saving it to mongoDB database (pre 'save' middleware for mongoose).
It have been getting complexity warnings and tried to rewrite it,...
7
votes
3
answers
3k
views
malloc in main() or malloc in another function: allocating memory for a struct and its members
When initializing a struct in C, we can allocate memory inside the main function or within another function and return a pointer to the newly created struct. This ...
- 181
1
vote
1
answer
96
views
Simple MySql or MySqli Class
Which one of these methods is better/safer to use? And what benefits could I get using one or other?
Simple mysqli:
connection.php
...
- 215
5
votes
1
answer
60
views
Comparing 2 iOS and Android versions
Please review and let me know which version is better. I'm just trying to find any caveats or better ways to accomplish the a version comparison independent from Android and iOS.
Formats accepted: '1....
- 51
1
vote
1
answer
344
views
Given a list and a number k return whether any two numbers from the list add up to k
The task:
Given a list of numbers and a number k, return whether any two numbers
from the list add up to k.
For example, given [10, 15, 3, 7] and k of 17, return true since 10 +
7 is 17.
...
- 3,973
2
votes
1
answer
1k
views
Clone Vector in rust except at one index [closed]
Let's consider you want to clone all items of a vector orig except the item of index i should be taken from alternative value <...
- 137
5
votes
1
answer
286
views
Two cross-platform implementations of getline in C
I created my cross-platform implementations of getline function in C.
It takes different arguments and have different return values than 'original' ...
- 525
1
vote
0
answers
104
views
No performance gain with SIMD 3D vector for ray tracer
I wrote two versions of vector class for my ray tracer. Non-SIMD version and SIMD version. You can find the code below. I want to ask what things should I keep in mind to get max performance with SIMD....
3
votes
0
answers
94
views
A Node and a Socket, template or inheritance? [closed]
I'm trying to create a node based scripting/computation system.
I've come up with 2 solution that seems to work. One involves template, the other one inheritance. Basically what I want to achieve is: ...
- 31
0
votes
1
answer
2k
views
Formatting milliseconds as days, hours, minutes, and seconds [closed]
This is a function which aims to convert an amount of milliseconds to a more human-interpretable Day(s) Hour(s) Minute(s) Second(s) format:
...
user196934
4
votes
0
answers
720
views
Kadane's algorithms to leetcode "121 Best Time to Buy and Sell Stock"
I employed the conventional Kadane's algorithms to solve a maximum subarray problem in leetcode Best Time to Buy and Sell Stock - LeetCode
Description
Best Time to Buy and Sell Stock
...
- 585
4
votes
1
answer
3k
views
4 solutions to leetcode 202. Happy Number have almost same performance
I am working on an easy math question Happy number Happy Number - LeetCode
Happy Number
Write an algorithm to determine if a number is "happy".
A happy number is a number defined by ...
- 585
4
votes
0
answers
483
views
Two solutions to leetcode 127.wordLadder
I am working on Word Ladder - LeetCode
Given two words (beginWord and endWord), and a dictionary's word list, find the length of shortest transformation sequence from beginWord to endWord, such ...
- 585
4
votes
1
answer
179
views
Time(n) Complexity of Fibonacci Algorithms
It is my first use of classes in Python. I wanted to create something useful and try some new things as I learn this cool language: strategy pattern, testing with nanoseconds precision, curve/poly ...
- 141
1
vote
0
answers
1k
views
Median of three partitioning taking more time than standard quicksort in java
I implemented a standard quicksort and I have a project where I need to improve it. I am trying to make quicksort faster by implementing median of 3 partitioning. I copied codes from trusted ...
- 19
0
votes
0
answers
165
views
Median of 3 partitioning taking more time than quicksort in java [duplicate]
I have a quicksort code in java which I want to improve. The improved code should take less time than the quicksort code. However when using my improved code which implement median of 3 partitioning, ...
- 19