This checks if a font is installed by using
grep. If the particular font is not installed, it offers to install it for the user. This snippet is part of a larger script that installs a particular Conky configuration along with all of its dependencies with minimal effort from the user.
- I have to create the
FONT_INSTALLEDvariable to avoid a "too many arguments" error by placing the code into the
ifstatement, is there a better practice for handling this?
- To check if the font is installed, I check if the
FONT_INSTALLEDvariable is a null
Stringor not. Is this considered good practice? I know in languages such as Java a
Stringis normally checked for length/content since the default value is "".
- I've seen that placing
> /dev/nullafter a command that would normally have output hides the output. This seems slightly 'hacky' as I know commands such as
--quietoption to hide output. For commands that do not have such an option, what is the preferred method of hiding output?
I realize that I should not place semi-colons after each line as per the advice on my first question first question. I forgot to make the appropriate changes to this code snippet.
FONT_INSTALLED=$(fc-list | grep -i "roboto"); if [ -z "$FONT_INSTALLED" ]; then echo "The Roboto font is not currently installed, would you like to install it now? (Y/N)"; read response if [[ "$response" == [yY] ]]; then echo "Installing the Roboto font to the ~/.fonts directory..."; mkdir .fonts/Roboto/ -p && wget --quiet -O ~/.fonts/Roboto/tmp.zip http://www.fontsquirrel.com/fonts/download/roboto && unzip ~/.fonts/Roboto/tmp.zip -d ~/.fonts/Roboto/ > /dev/null && rm ~/.fonts/Roboto/tmp.zip fc-cache -fv > /dev/null FONT_INSTALLED=$(fc-list | grep -i "roboto"); if [ -n "$FONT_INSTALLED" ]; then echo "The Roboto font was sucessfully installed!"; else echo "Something went wrong while trying to install the Roboto font."; fi else echo "Skipping the installation of the Roboto font..."; echo "Please note that this Conky configuration will not work without the Roboto font."; fi else echo "The Roboto font has already been installed."; fi